Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 30 Apr 2025 20:07:54 +0200
From:      Dimitry Andric <dim@FreeBSD.org>
To:        Ed Maste <emaste@freebsd.org>
Cc:        Philip Paeps <philip@freebsd.org>, src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org
Subject:   Re: git: 91506dba7f2e - main - zoneinfo: also install tzdata.zi and version
Message-ID:  <A2F733DB-6007-4570-815A-5CDCBF8F7B91@FreeBSD.org>
In-Reply-To: <CAPyFy2ADpLbWQ7XaKM63XzGtN9Or083kdMUnf=DCNPyKaCpY6w@mail.gmail.com>
References:  <202504010810.5318A96d073963@gitrepo.freebsd.org> <CAPyFy2DF4TgxO9U=VcFnFn2HkPSpgXeErpp0gnu9fBta4-nU0Q@mail.gmail.com> <CFB03C3A-06C6-4DD8-888D-7B87EC629856@freebsd.org> <CAPyFy2ADpLbWQ7XaKM63XzGtN9Or083kdMUnf=DCNPyKaCpY6w@mail.gmail.com>

next in thread | previous in thread | raw e-mail | index | archive | help
On 30 Apr 2025, at 18:58, Ed Maste <emaste@freebsd.org> wrote:
>=20
> On Wed, 30 Apr 2025 at 00:58, Philip Paeps <philip@freebsd.org> wrote:
>>=20
>> On 2025-04-30 02:44:46 (+0800), Ed Maste wrote:
>>> On Tue, 1 Apr 2025 at 04:10, Philip Paeps <philip@freebsd.org> =
wrote:
>>>> The branch main has been updated by philip:
>>>>=20
>>>> URL:
>>>> =
https://cgit.FreeBSD.org/src/commit/?id=3D91506dba7f2eb147eeb55ec30640bc11=
755a1e8e
>>>>=20
>>>> commit 91506dba7f2eb147eeb55ec30640bc11755a1e8e
>>>> Author:     Philip Paeps <philip@FreeBSD.org>
>>>> AuthorDate: 2025-04-01 08:09:37 +0000
>>>> Commit:     Philip Paeps <philip@FreeBSD.org>
>>>> CommitDate: 2025-04-01 08:09:37 +0000
>>>>=20
>>>>    zoneinfo: also install tzdata.zi and version
>>>>=20
>>>>    Build and install the shrunk version of the time zone database
>>>> required
>>>>    by libc++ 19 std::chrono::current_zone (etc).  While here, also
>>>> install
>>>>    the tzdata 'version' file to align more closely with other
>>>> vendors.
>>>>=20
>>>>    PR:             282377
>>>>    Reviewed by:    dim, emaste, imp
>>>>    Differential Revision:  https://reviews.freebsd.org/D49577
>>>=20
>>> Do you plan to MFC this to stable/14 for 14.3 as well?
>>=20
>> I was not planning to MFC this change.
>>=20
>> Does libc++ in stable/14 need this support?
>=20
> I suspect so - std::chrono::tzdb is C++20 and we presumably want it to
> exist/work in stable/14.  Dimitry?

The tzdata.zi file is a prerequisite, but I never got to completely
verifying that it actually works. At some point I had a hand-concocted
file, but libc++ fell over on it. I'm unsure what the status is now.

-Dimitry




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?A2F733DB-6007-4570-815A-5CDCBF8F7B91>