From owner-cvs-src@FreeBSD.ORG Tue May 20 23:41:11 2008 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D5FE4106566C; Tue, 20 May 2008 23:41:11 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by mx1.freebsd.org (Postfix) with ESMTP id BF0408FC19; Tue, 20 May 2008 23:41:11 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (server.baldwin.cx [208.65.91.234]) by elvis.mu.org (Postfix) with ESMTP id 636631A4D7C; Tue, 20 May 2008 16:41:11 -0700 (PDT) Received: from localhost.corp.yahoo.com (john@localhost [127.0.0.1]) (authenticated bits=0) by server.baldwin.cx (8.14.2/8.14.2) with ESMTP id m4KNf3Xe054625; Tue, 20 May 2008 19:41:04 -0400 (EDT) (envelope-from jhb@freebsd.org) From: John Baldwin To: "David E. O'Brien" Date: Tue, 20 May 2008 19:40:55 -0400 User-Agent: KMail/1.9.7 References: <200805202254.m4KMsgoO088002@repoman.freebsd.org> In-Reply-To: <200805202254.m4KMsgoO088002@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200805201940.56151.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]); Tue, 20 May 2008 19:41:04 -0400 (EDT) X-Virus-Scanned: ClamAV 0.91.2/7184/Tue May 20 17:23:20 2008 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/gnu/usr.bin/gdb/kgdb trgt_mips.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 May 2008 23:41:12 -0000 On Tuesday 20 May 2008 06:54:42 pm David E. O'Brien wrote: > obrien 2008-05-20 22:54:42 UTC > > FreeBSD src repository > > Added files: > gnu/usr.bin/gdb/kgdb trgt_mips.c > Log: > MIPS arch target kgdb(1) support. > > Obtained from: Juniper Networks. Check for recent changes in the other MD backends. Things I noticed: - You should use ptid_get_pid() rather than ptid_get_tid() in kgdb_trgt_fetch_registers() (this is part of the changes to allow the 'tid' command to work over remote gdb). - You are missing a 'kgdb_trgt_new_objfile()' stub. The latter, at least, should have resulted in a link error. -- John Baldwin