From owner-svn-src-head@FreeBSD.ORG Tue Jan 4 17:06:03 2011 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 734D41065670; Tue, 4 Jan 2011 17:06:03 +0000 (UTC) (envelope-from jkim@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c]) by mx1.freebsd.org (Postfix) with ESMTP id 62CA58FC1C; Tue, 4 Jan 2011 17:06:03 +0000 (UTC) Received: from svn.freebsd.org (localhost [127.0.0.1]) by svn.freebsd.org (8.14.3/8.14.3) with ESMTP id p04H630u047424; Tue, 4 Jan 2011 17:06:03 GMT (envelope-from jkim@svn.freebsd.org) Received: (from jkim@localhost) by svn.freebsd.org (8.14.3/8.14.3/Submit) id p04H63Xx047422; Tue, 4 Jan 2011 17:06:03 GMT (envelope-from jkim@svn.freebsd.org) Message-Id: <201101041706.p04H63Xx047422@svn.freebsd.org> From: Jung-uk Kim Date: Tue, 4 Jan 2011 17:06:03 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Subject: svn commit: r216965 - head/sys/dev/acpica X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Jan 2011 17:06:03 -0000 Author: jkim Date: Tue Jan 4 17:06:03 2011 New Revision: 216965 URL: http://svn.freebsd.org/changeset/base/216965 Log: Clarify the previous commit. AcpiFinishGpe() will not clear GPE for us because we set it to edge-trigger. Modified: head/sys/dev/acpica/acpi_ec.c Modified: head/sys/dev/acpica/acpi_ec.c ============================================================================== --- head/sys/dev/acpica/acpi_ec.c Tue Jan 4 16:51:24 2011 (r216964) +++ head/sys/dev/acpica/acpi_ec.c Tue Jan 4 17:06:03 2011 (r216965) @@ -685,10 +685,12 @@ EcGpeQueryHandler(void *Context) device_printf(sc->ec_dev, "evaluation of query method %s failed: %s\n", qxx, AcpiFormatException(Status)); } + + /* Reenable runtime GPE if its execution was deferred. */ if (sci_enqueued) { Status = AcpiFinishGpe(sc->ec_gpehandle, sc->ec_gpebit); if (ACPI_FAILURE(Status)) - device_printf(sc->ec_dev, "clearing GPE failed: %s\n", + device_printf(sc->ec_dev, "reenabling runtime GPE failed: %s\n", AcpiFormatException(Status)); } }