From owner-cvs-all Sat Jul 13 3:39:17 2002 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D8B0C37B400; Sat, 13 Jul 2002 03:39:12 -0700 (PDT) Received: from zibbi.icomtek.csir.co.za (zibbi.icomtek.csir.co.za [146.64.24.58]) by mx1.FreeBSD.org (Postfix) with ESMTP id A3DD843E58; Sat, 13 Jul 2002 03:39:07 -0700 (PDT) (envelope-from jhay@zibbi.icomtek.csir.co.za) Received: (from jhay@localhost) by zibbi.icomtek.csir.co.za (8.11.6/8.11.6) id g6DAcOf99141; Sat, 13 Jul 2002 12:38:24 +0200 (SAT) (envelope-from jhay) From: John Hay Message-Id: <200207131038.g6DAcOf99141@zibbi.icomtek.csir.co.za> Subject: Re: cvs commit: src/sys/netinet udp_usrreq.c In-Reply-To: <200207121628.g6CGS3wr014471@gw.catspoiler.org> from Don Lewis at "Jul 12, 2002 09:28:03 am" To: dl@catspoiler.org (Don Lewis) Date: Sat, 13 Jul 2002 12:38:24 +0200 (SAT) Cc: imp@bsdimp.com, hsu@FreeBSD.org, truckman@FreeBSD.org, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org X-Mailer: ELM [version 2.4ME+ PL54 (25)] MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG > > In message: <0GZ4004U3MZCIJ@mta5.snfc21.pbi.net> > > Jeffrey Hsu writes: > > : > Lock inp while we're accessing it. > > : > > : Here's a rhetorical question: why? That inp was purposely left unlocked. > > > > I can only assume that he didn't have enough: > > > > ../../../vm/uma_core.c:1332: could sleep with "inp" locked from ../../../netinet/tcp_usrreq.c:536 > > > > messages in his dmesg log. > > I checked in a fix for that violation last night. SYSCTL_OUT() can > block, so calling it with a lock held will cause this error. This > particular case was easy to fix by moving the call to SYSCTL_OUT() > outside the locked region. I still get one like that when connecting to the box using ssh over ipv6. Actually any ipv6 tcp connection to the box wil print that. Just one message per connection. John -- John Hay -- John.Hay@icomtek.csir.co.za / jhay@FreeBSD.org To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message