From owner-svn-src-all@freebsd.org Fri Feb 22 15:03:43 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 5DCDA14EEDF3; Fri, 22 Feb 2019 15:03:43 +0000 (UTC) (envelope-from dab0816@gmail.com) Received: from mail-it1-x12b.google.com (mail-it1-x12b.google.com [IPv6:2607:f8b0:4864:20::12b]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id DFACB704EF; Fri, 22 Feb 2019 15:03:42 +0000 (UTC) (envelope-from dab0816@gmail.com) Received: by mail-it1-x12b.google.com with SMTP id m137so3357292ita.0; Fri, 22 Feb 2019 07:03:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:message-id:mime-version:subject:date:in-reply-to:cc:to :references; bh=GqIEBhx8C25T7neNHDFf07DbOxBxYPpOIUcZOEHSTYI=; b=hyu8U9Cw9I9VFxLTFH7FWjSo55g3TAvLIDkEe6CrzWoYO2m04yg0lZW4vXtStu1vUK 8LJndMYseraFj5QNmZ3BVPVyaRwTe4nQTppLZrjsbcuoeO5wzNvIu44ln4aLCOqWYJ9g W7kqmqhRUlirbHeY+L/uuhy9FRxdBKn49GwR5O6m01I1BPjp3rZpWjhwtOyoIM/CHCqG aNsOvWNRu48AVmojjPKQAlB55b28pdPzDXXMOg8aPmUzPs9pODYDl1wS4Tt0MXDXkRMd F6KGCJCcyr62CvOv9vbg/0t3whLyVi/tzm7vlvpBJlLc1ZejdQsCZR4J90aZMrlCWOG8 A8MA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:message-id:mime-version:subject:date :in-reply-to:cc:to:references; bh=GqIEBhx8C25T7neNHDFf07DbOxBxYPpOIUcZOEHSTYI=; b=blbzC5Evop8KPHBCGtKZZbvdUpx1pjF6abTqecxNyWIhEYW8/bfIek0sOZ4RhW8t/l xpBBwo/4+LOqFO5nKFBxlT9Nwv7Ando5FOzM94vCJRbjy2ylQiC0ksDrBo8L4t2ROh58 OB8tEtU9C/HmaDPhmjgLMKYiYgNUnjs9agAwp7o8YemKUxzjyRv7z1nTm2Uqv3ZNNnOH PmlBPivRkIptpImA+IaXUoHvrNb0mBrp0aVqhvcpfqycasGjZ48ZpwGHQSGMOuLjlrLH hgxCjpsLtuD7uF2+aFHuyMV6ok0L6XXBAi8yp/SQEiJv1CM++yI2Pd8BtBCo9uyfWnHH 9gGQ== X-Gm-Message-State: AHQUAuaaKx28QlO2MhWCPKbCVupECdNeDK+z9jszw27+CWx3ymYzycCk 7rTvD5rqZ3S1Isrwa91EXV8JWDuF X-Google-Smtp-Source: AHgI3IY7AVJr/rZzFyWYoJShPXImLSvOq8K1XgvaiUvI5K68h+XGL7O9/zHZxX6F6GKTwaDMNJJRLQ== X-Received: by 2002:a24:4a95:: with SMTP id k143mr2397177itb.77.1550847821991; Fri, 22 Feb 2019 07:03:41 -0800 (PST) Received: from ?IPv6:2601:442:4580:3ee3:d1f4:bd82:e7a5:4239? ([2601:442:4580:3ee3:d1f4:bd82:e7a5:4239]) by smtp.gmail.com with ESMTPSA id w13sm793099itb.10.2019.02.22.07.03.40 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 22 Feb 2019 07:03:41 -0800 (PST) Sender: David Bright From: David Bright X-Google-Original-From: David Bright Message-Id: Mime-Version: 1.0 (Mac OS X Mail 12.2 \(3445.102.3\)) Subject: Re: svn commit: r344389 - head/usr.sbin/newsyslog Date: Fri, 22 Feb 2019 09:03:39 -0600 In-Reply-To: Cc: Warner Losh , Garrett Cooper , Bruce Evans , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org To: John Baldwin References: <201902202205.x1KM5iZX036319@repo.freebsd.org> <20190221121712.Y989@besplex.bde.org> <3CD59489-0595-4D09-B5C9-C3F25D23BB8D@gmail.com> X-Mailer: Apple Mail (2.3445.102.3) X-Rspamd-Queue-Id: DFACB704EF X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.96 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.96)[-0.957,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Feb 2019 15:03:43 -0000 [=E2=80=A6 other discussion omitted=E2=80=A6]=20 On Feb 21, 2019, at 12:22 PM, John Baldwin wrote: >=20 >=20 > I'm +1 on Bruce's point on this. I find it similar to the recent = spate of > adding pointless '__dead2' annotations to usage functions that = unconditionally > call exit() (and thus are already inferred as __dead2 by any compiler > written in this millenium) I=E2=80=99ve reverted (r344468) the two commits that contained the = memory leak fixes at issue.=20 Thanks for the feedback. --=20 David Bright dab@FreeBSD.org