From nobody Tue Jul 26 20:45:13 2022 X-Original-To: bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Lspnk4Jfrz4X8VY for ; Tue, 26 Jul 2022 20:45:14 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Lspnk39MNz3PdF for ; Tue, 26 Jul 2022 20:45:14 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Lspnk26fpzrNX for ; Tue, 26 Jul 2022 20:45:14 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 26QKjED4007000 for ; Tue, 26 Jul 2022 20:45:14 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 26QKjEO9006999 for bugs@FreeBSD.org; Tue, 26 Jul 2022 20:45:14 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 265461] "skein* -q -c " command returns 0 exit code with '-q' and with incorrect skein string Date: Tue, 26 Jul 2022 20:45:13 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bin X-Bugzilla-Version: 13.1-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: se@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc flagtypes.name attachments.created Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-bugs@freebsd.org MIME-Version: 1.0 ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1658868314; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XDuIpAwIrpeK06ByzU+0i1M6dT/OvTZHaD8cFCo7w4A=; b=dNiIO82EpJ7zTeDSBZfPsHGpbJJidcABwmWKmamyv/ipKqQUSyBktxGpQ0qX/7X+s/IWXJ oveAvRFWZMEL2GSPzZY/ldakhxb5PlG88cb0DyhfWUJaxbVTF5sStM4pVuipyo0aIrafkG 3FagjnPzFfYcftcHkzYugFvbYBaRTPJOfHWYevzX+C6DY1hdLDISwQGHuM/UeT+fQldbn/ ySHMwL1a6iXnqT+fvuSgz8eG3RdyQa/vJkHmrtHIAaBkb/J3sNXP06w2tB9Y9HlBwfDu7H eVewV1FdQ6G1u5Km40GUslw4X84entS+QN+q8iCgzz4KH/3ZgjsLhj+4ujdU1Q== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1658868314; a=rsa-sha256; cv=none; b=CyHJCTRboPX1nqEcRy/BFbLywd9UaEZL7AD3RU6eJEm3Dap5Yj3sML+dcHI2uByY6xRYSB KF0dQuxNujY1rFi8HD4Fx5IO7iW6PGQNZ70w8MGrZSnP7q7f1FY3HRmeeemaLd6/J/AIAj 5oNkhdU0aKTWOGyqnJGRbFsB9WheyysAx7LOZzJvqLqmH0gOYnMmZZgtrkoJcGqjcsQt5u AAuAxwZ+UjYpRoIikb44jyLNHToHa4+5pPNU/HMR0GANTkdHk73Xn0etwKAxHvyvwwuPaj vVSpVU+Obgoj1J3ziuYRv1SixVgKjZJ4Tqbo9bOIEpkfXHKgVcaWMROEa05mxQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D265461 Stefan E=C3=9Fer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |se@FreeBSD.org Attachment #235498| |maintainer-approval+ Flags| | --- Comment #4 from Stefan E=C3=9Fer --- Created attachment 235498 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D235498&action= =3Dedit Make skein256 -q -c return 2 on mismatch The man page does not state that skein256 -q -c should an return non-zero exit status if the passed hash does not match the contents of the file. But it seems obvious, that this was an oversight. If the -c option is ignor= ed if combined with -q, it should not be rejected to let the user know that the combination is not supported. The attached patch makes -q -c do what the man page says: it prints = the calculated hash. And it adds the exist status that results from the check performed by the -c option. --=20 You are receiving this mail because: You are the assignee for the bug.=