From owner-cvs-all@FreeBSD.ORG  Sun Nov 20 21:46:17 2005
Return-Path: <owner-cvs-all@FreeBSD.ORG>
X-Original-To: cvs-all@FreeBSD.org
Delivered-To: cvs-all@FreeBSD.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id A3AF616A420;
	Sun, 20 Nov 2005 21:46:17 +0000 (GMT) (envelope-from nate@root.org)
Received: from www.cryptography.com (li-22.members.linode.com [64.5.53.22])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 5134D43D4C;
	Sun, 20 Nov 2005 21:46:13 +0000 (GMT) (envelope-from nate@root.org)
Received: from [10.0.5.50] (ppp-71-139-0-107.dsl.snfc21.pacbell.net
	[71.139.0.107])
	by www.cryptography.com (8.12.8/8.12.8) with ESMTP id jAKLkFDe032426
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT);
	Sun, 20 Nov 2005 13:46:16 -0800
Message-ID: <4380EE85.1040509@root.org>
Date: Sun, 20 Nov 2005 13:45:41 -0800
From: Nate Lawson <nate@root.org>
User-Agent: Mozilla Thunderbird 1.0.6 (Windows/20050716)
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Lukas Ertl <le@FreeBSD.org>
References: <20051120121247.873A316A45B@hub.freebsd.org>
In-Reply-To: <20051120121247.873A316A45B@hub.freebsd.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/geom/vinum geom_vinum_rename.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 20 Nov 2005 21:46:18 -0000

Lukas Ertl wrote:
> le          2005-11-20 12:12:31 UTC
> 
>   FreeBSD src repository
> 
>   Modified files:
>     sys/geom/vinum       geom_vinum_rename.c 
>   Log:
>   Always declare variables at the start of the function.
>   Don't allocate potentially large variables on the stack.
>   Check strsep() return values when the string comes from userland.
>   Shorten variable names for lucidity's sake.
>   
>   most of the stuff:
>   Pointed out by:    njl@
>   
>   Revision  Changes    Path
>   1.2       +110 -47   src/sys/geom/vinum/geom_vinum_rename.c

Excellent, thank you!

-- 
Nate