From owner-svn-src-head@freebsd.org  Sat Jun 23 16:16:57 2018
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 5C73D10267B5;
 Sat, 23 Jun 2018 16:16:57 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
 [IPv6:2610:1c1:1:6074::16:84])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "freefall.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 03A33891DE;
 Sat, 23 Jun 2018 16:16:57 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: by freefall.freebsd.org (Postfix, from userid 1033)
 id EC616135BC; Sat, 23 Jun 2018 16:16:56 +0000 (UTC)
Date: Sat, 23 Jun 2018 16:16:56 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: Eitan Adler <eadler@FreeBSD.org>
Cc: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Subject: Re: svn commit: r335547 - head/usr.bin/top
Message-ID: <20180623161656.GB91517@FreeBSD.org>
References: <201806220945.w5M9jI5H044405@repo.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201806220945.w5M9jI5H044405@repo.freebsd.org>
User-Agent: Mutt/1.9.5 (2018-04-13)
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.26
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 23 Jun 2018 16:16:57 -0000

On Fri, Jun 22, 2018 at 09:45:18AM +0000, Eitan Adler wrote:
> New Revision: 335547
> URL: https://svnweb.freebsd.org/changeset/base/335547
> 
> Log:
>   top(1): remove special handling of load > 5
>   
> ...
> Modified: head/usr.bin/top/screen.c
> ==============================================================================
> --- head/usr.bin/top/screen.c	Fri Jun 22 09:41:13 2018	(r335546)
> +++ head/usr.bin/top/screen.c	Fri Jun 22 09:45:18 2018	(r335547)
> @@ -55,7 +55,7 @@ static struct termios new_settings;
>  static char is_a_terminal = false;
>  
>  void
> -init_termcap(int interactive)
> +init_termcap(bool interactive)
>  {
>      char *bufptr;
>      char *PCptr;
> @@ -138,7 +138,7 @@ init_termcap(int interactive)
>      /* get "ce", clear to end */
>      if (!overstrike)
>      {
> -	clear_line = tgetstr("ce", &bufptr);
> +		clear_line = tgetstr("ce", &bufptr);
>      }

(I've seen it before, and replying to this commit as an example): would
you mind separating style and functional changes into different commits?
I know that top(1) is full of style bugs and it's very tempting to fix
them when you see them, but that's not really the best way to go.

./danfe