From owner-svn-src-all@FreeBSD.ORG  Sat Oct 20 15:39:10 2012
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
 by hub.freebsd.org (Postfix) with ESMTP id DB4F6BB5;
 Sat, 20 Oct 2012 15:39:10 +0000 (UTC)
 (envelope-from andreast@FreeBSD.org)
Received: from smtp.fgznet.ch (mail.fgznet.ch [81.92.96.47])
 by mx1.freebsd.org (Postfix) with ESMTP id 698A28FC08;
 Sat, 20 Oct 2012 15:39:09 +0000 (UTC)
Received: from deuterium.andreas.nets (dhclient-91-190-14-19.flashcable.ch
 [91.190.14.19])
 by smtp.fgznet.ch (8.13.8/8.13.8/Submit_SMTPAUTH) with ESMTP id q9KFd1fi057382;
 Sat, 20 Oct 2012 17:39:01 +0200 (CEST)
 (envelope-from andreast@FreeBSD.org)
Message-ID: <5082C595.3040504@FreeBSD.org>
Date: Sat, 20 Oct 2012 17:39:01 +0200
From: Andreas Tobler <andreast@FreeBSD.org>
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.5;
 rv:15.0) Gecko/20120907 Thunderbird/15.0.1
MIME-Version: 1.0
To: Ed Schouten <ed@FreeBSD.org>
Subject: Re: svn commit: r241777 - in head: bin/dd libexec/rpc.rusersd
 libexec/talkd
 usr.bin/cksum usr.bin/m4 usr.sbin/mtree usr.sbin/newsyslog
 usr.sbin/services_mkdb
References: <201210201033.q9KAXGRm007583@svn.freebsd.org>
In-Reply-To: <201210201033.q9KAXGRm007583@svn.freebsd.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-Scanned-By: MIMEDefang 2.64 on 81.92.96.47
Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org,
 src-committers@FreeBSD.org
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 20 Oct 2012 15:39:10 -0000

On 20.10.12 12:33, Ed Schouten wrote:
> Author: ed
> Date: Sat Oct 20 10:33:15 2012
> New Revision: 241777
> URL: http://svn.freebsd.org/changeset/base/241777
>
> Log:
>    More -Wmissing-variable-declarations fixes.
>
>    In addition to adding missing `static' keywords:
>    - bin/dd: Pull in `extern.h' to guarantee consistency with source file.
>    - libexec/rpc.rusersd: Move shared globals into an extern.h.
>    - libexec/talkd: Move `debug' and `hostname' into extern.h.
>    - usr.bin/cksum: Put counters in extern.h, as they are used by ckdist/mtree.
>    - usr.bin/m4: Move `end_result' into extern.h.
>    - usr.sbin/services_mkdb: Move shared globals into an extern.h.

Hi Ed,

I get the same failures (on amd64/powerpc64) as the TB on mips for example:

/src/usr.bin/m4/parser.y:26:18: error: mdef.h: No such file or directory
/src/usr.bin/m4/parser.y:27:20: error: extern.h: No such file or directory

Is this the right fix?

TIA,
Andreas

Index: Makefile
===================================================================
--- Makefile	(revision 241783)
+++ Makefile	(working copy)
@@ -5,7 +5,7 @@
  # 	if you want the paste & spaste macros.

  PROG=	m4
-CFLAGS+=-DEXTENDED -I${.CURDIR}/lib
+CFLAGS+=-DEXTENDED -I${.CURDIR} -I${.CURDIR}/lib
  LDADD=	-ly -ll -lm
  # clang needs 1 while with gcc we can use 2
  #WARNS=	1