From owner-cvs-all@FreeBSD.ORG Fri Mar 26 10:14:13 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5DF6A16A4CE; Fri, 26 Mar 2004 10:14:13 -0800 (PST) Received: from fledge.watson.org (fledge.watson.org [204.156.12.50]) by mx1.FreeBSD.org (Postfix) with ESMTP id DC08343D1D; Fri, 26 Mar 2004 10:14:12 -0800 (PST) (envelope-from robert@fledge.watson.org) Received: from fledge.watson.org (localhost [127.0.0.1]) by fledge.watson.org (8.12.10/8.12.10) with ESMTP id i2QIBwxC082466; Fri, 26 Mar 2004 13:11:58 -0500 (EST) (envelope-from robert@fledge.watson.org) Received: from localhost (robert@localhost)i2QIBvns082462; Fri, 26 Mar 2004 13:11:58 -0500 (EST) (envelope-from robert@fledge.watson.org) Date: Fri, 26 Mar 2004 13:11:57 -0500 (EST) From: Robert Watson X-Sender: robert@fledge.watson.org To: Garance A Drosehn In-Reply-To: <200403261751.i2QHpn5V048897@repoman.freebsd.org> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.bin/pkill pkill.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Mar 2004 18:14:13 -0000 On Fri, 26 Mar 2004, Garance A Drosehn wrote: > Modified files: > usr.bin/pkill pkill.c > Log: > Switch to checking P_KTHREAD instead of P_SYSTEM when deciding what > "system processes" to always ignore. Based on my testing with `-D', > I am pretty sure this is what we want for 5.x-current. If my thinking > is wrong, this also makes it easier to switch to a different check. Either our definition or my understanding of P_KTHREAD vs P_SYSTEM is weak. P_SYSTEM seems to include init, and P_KTHREAD seems to mean things that really are kprocs, but there was some recent discussion of the details of this on arch@ with regard to whether signals should be delivered to things that are arguably kernel threads or processes. Robert N M Watson FreeBSD Core Team, TrustedBSD Projects robert@fledge.watson.org Senior Research Scientist, McAfee Research