From owner-cvs-src@FreeBSD.ORG Mon Jun 13 20:28:54 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 053C516A41C; Mon, 13 Jun 2005 20:28:54 +0000 (GMT) (envelope-from scottl@samsco.org) Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57]) by mx1.FreeBSD.org (Postfix) with ESMTP id 90D3943D48; Mon, 13 Jun 2005 20:28:49 +0000 (GMT) (envelope-from scottl@samsco.org) Received: from [192.168.254.14] (imini.samsco.home [192.168.254.14]) (authenticated bits=0) by pooker.samsco.org (8.13.3/8.13.3) with ESMTP id j5DKXahD006531; Mon, 13 Jun 2005 14:33:36 -0600 (MDT) (envelope-from scottl@samsco.org) Message-ID: <42ADEBE4.2020308@samsco.org> Date: Mon, 13 Jun 2005 14:26:12 -0600 From: Scott Long User-Agent: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.7.7) Gecko/20050416 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Jeff Roberson References: <200506122232.j5CMWTIb020093@repoman.freebsd.org> <42ACBADB.70109@samsco.org> <20050612202915.C16943@mail.chesapeake.net> <20050612203027.B16943@mail.chesapeake.net> In-Reply-To: <20050612203027.B16943@mail.chesapeake.net> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.8 required=3.8 tests=ALL_TRUSTED autolearn=failed version=3.0.2 X-Spam-Checker-Version: SpamAssassin 3.0.2 (2004-11-16) on pooker.samsco.org Cc: cvs-src@FreeBSD.org, Jeff Roberson , src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern subr_disk.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Jun 2005 20:28:54 -0000 Jeff Roberson wrote: > On Sun, 12 Jun 2005, Jeff Roberson wrote: > > >>On Sun, 12 Jun 2005, Scott Long wrote: >> >> >>>Jeff Roberson wrote: >>> >>> >>>>jeff 2005-06-12 22:32:29 UTC >>>> >>>> FreeBSD src repository >>>> >>>> Modified files: >>>> sys/kern subr_disk.c >>>> Log: >>>> - Dramatically simplify bioqdisksort(). We no longer do ordered bios so >>>> most of the code to deal with them has been dead for sometime. Simplify >>>> the code by doing an insert sort hinted by the current head position. >>>> >>>> Met with apathy by: arch@ >>>> >>>> Revision Changes Path >>>> 1.84 +40 -85 src/sys/kern/subr_disk.c >>> >>>Not exactly apathy, just lack of time ;-( I trust that this has been >>>adequately tested on many different workloads? Also, how exactly does >>>this fall under your blanket approval to fix VFS? >> >>I was not aware of any current code freeze. Is there one? > > > I see, sorry. I missed by 24hrs. I was waiting for feedback on arch, but > I've been running with this patch for some time. > > Speaking of the freeze, I'd really like to get the interrupt thread perf > fixes in before 6.0. I think it should be a priority to fix ithread > performance. > This sounds fine, just send an email to re@ about it since it falls outside of your existing blanket approval. Scott