From owner-svn-src-all@FreeBSD.ORG Mon Oct 11 18:32:42 2010 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 49823106566B; Mon, 11 Oct 2010 18:32:42 +0000 (UTC) (envelope-from ivoras@gmail.com) Received: from mail-qw0-f54.google.com (mail-qw0-f54.google.com [209.85.216.54]) by mx1.freebsd.org (Postfix) with ESMTP id 9A16A8FC08; Mon, 11 Oct 2010 18:32:41 +0000 (UTC) Received: by qwe4 with SMTP id 4so1617423qwe.13 for ; Mon, 11 Oct 2010 11:32:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:mime-version:sender:received :in-reply-to:references:from:date:x-google-sender-auth:message-id :subject:to:cc:content-type:content-transfer-encoding; bh=cyHmBRSrCzlsawe+iQCWXAqRSHHeK3OBxUZkSXT26+M=; b=TrudmdffYQJZRY0pRMn7T/nzBUVqWxgc1z1e/xqdfBfQCNy1b+b4MVS3xjl+ozWh6t 38LydIWhMj8ilnwVzwS8osmdZFwzXnpaHd/cA/sByqTtW/GSAmw9lBnghy57mNu65Y38 cRlDkaFtTEyVzrGt5rlGYZGXaS/QnQbibmaEI= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type :content-transfer-encoding; b=c89QnIxB5nGOMDnRTAMSMbd598IJCwsEJpmEdz2K7kTFC5w1Yhm1PnG3tmohEYf/dT ddHhqXkNf3/0F6Im69L3gHnyTM69Ko/pMXWDyrhShaahwk44osAj1/yWhGHqQzzRnAU3 1n60/dWX3DwkGNS/XGvFmLN9GSlXMJFZ3mcU0= Received: by 10.224.209.6 with SMTP id ge6mr4747438qab.110.1286821960645; Mon, 11 Oct 2010 11:32:40 -0700 (PDT) MIME-Version: 1.0 Sender: ivoras@gmail.com Received: by 10.229.234.81 with HTTP; Mon, 11 Oct 2010 11:32:00 -0700 (PDT) In-Reply-To: References: <201010092020.o99KKSYW051470@svn.freebsd.org> From: Ivan Voras Date: Mon, 11 Oct 2010 20:32:00 +0200 X-Google-Sender-Auth: GBzyGdZJvfEIFqe6yGKLm5J-acY Message-ID: To: "Andrey V. Elsukov" Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r213662 - in head: sbin/geom/class/concat sbin/geom/class/eli sbin/geom/class/journal sbin/geom/class/mirror sbin/geom/class/part sbin/geom/class/raid3 sbin/geom/class/shsec sbin/geom/c... X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Oct 2010 18:32:42 -0000 On 10 October 2010 10:54, Ivan Voras wrote: > On 9 October 2010 22:20, Andrey V. Elsukov wrote: >> Author: ae >> Date: Sat Oct =C2=A09 20:20:27 2010 >> New Revision: 213662 >> URL: http://svn.freebsd.org/changeset/base/213662 >> >> Log: >> =C2=A0Replace strlen(_PATH_DEV) with sizeof(_PATH_DEV) - 1. > > Um, this looks like a pointless change and for the worse; Even at -O1 > the compiler will reduce strlen(constant) to just its result and for > code like printf("%d\n", sizeof("1234567")) produce code like: ^^^^^ should be strlen(), of course :)