From owner-freebsd-rc@FreeBSD.ORG  Sat Nov 10 10:38:25 2012
Return-Path: <owner-freebsd-rc@FreeBSD.ORG>
Delivered-To: freebsd-rc@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
 by hub.freebsd.org (Postfix) with ESMTP id C30D765E;
 Sat, 10 Nov 2012 10:38:25 +0000 (UTC)
 (envelope-from utisoft@gmail.com)
Received: from mail-bk0-f54.google.com (mail-bk0-f54.google.com
 [209.85.214.54])
 by mx1.freebsd.org (Postfix) with ESMTP id 2C37A8FC13;
 Sat, 10 Nov 2012 10:38:24 +0000 (UTC)
Received: by mail-bk0-f54.google.com with SMTP id jm19so891308bkc.13
 for <multiple recipients>; Sat, 10 Nov 2012 02:38:24 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:from:date:message-id:subject:to:content-type;
 bh=uYbU6Ru69t/DeoIrsrMdSX8CcQe6qBpqeR9EuCSoZ8M=;
 b=bBg2Mz8qrbi9oaW8X8qrc9VTd56pK9ChUViSfgqs0Iq1+0mDAFr6D+20vGM/Kg+gZs
 4oH00Y6k4XD54Kqegg5SPuRAxtDcn8x/yDSMoeZiwTtptW8y7PHLwq6rETwXa1w6BO6l
 IzDCSZz73yPiYBLu/nhWw3EQcWhayJkpumheiM6659rmyVin4oZDNKvnVR41vYbStKxW
 LI29yqhfUqmZKZW69EFn+VpmVxi5mdkGgRV3tnQLiRQefsc3zIbzAXsf4KC8h0uyvc3E
 OjEiUXZJiWl/Eh331HYo26VjDpEfRUD2LF6XSkdnpRK08imzw8V9Ehg19v0fgGKsMx+F
 GlLA==
Received: by 10.204.128.201 with SMTP id l9mr4692263bks.66.1352543904236; Sat,
 10 Nov 2012 02:38:24 -0800 (PST)
MIME-Version: 1.0
Received: by 10.204.50.197 with HTTP; Sat, 10 Nov 2012 02:37:53 -0800 (PST)
From: Chris Rees <utisoft@gmail.com>
Date: Sat, 10 Nov 2012 10:37:53 +0000
Message-ID: <CADLo83-L-GuuK_aqyzNEriRMJsDczroujt5kHHazKDh_4qWeyw@mail.gmail.com>
Subject: Re: jail: unknown parameter: ip6.addr
To: jail@freebsd.org, "freebsd-rc@freebsd.org" <freebsd-rc@freebsd.org>
Content-Type: text/plain; charset=ISO-8859-1
X-BeenThere: freebsd-rc@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: "Discussion related to /etc/rc.d design and implementation."
 <freebsd-rc.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-rc>,
 <mailto:freebsd-rc-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-rc>
List-Post: <mailto:freebsd-rc@freebsd.org>
List-Help: <mailto:freebsd-rc-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-rc>,
 <mailto:freebsd-rc-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 10 Nov 2012 10:38:25 -0000

[adding rc@, please keep me CCd as I'm not in jail@]

On Thu, 2012-11-08 at 02:27 +0100, Mateusz Guzik wrote:
> On Wed, Nov 07, 2012 at 03:39:26PM -0500, Mike Jakubik wrote:
> > Hello,
> >
> > I just updated a server to latest stable and my jails no longer start,
> > troubleshooting the startup script shows us that the parameter ip6.addr
> > is unknown, this system is compiled without INET6.
> [..]
> > + tail +2 /tmp/jail.PJ5ji3QH/jail.8101
> > jail: unknown parameter: ip6.addr
>
> Try this (lightly tested):
> http://people.freebsd.org/~mjg/patches/rc-jail-ip-arg.diff
>
> Basically the idea is to pass ip4.addr and ip6.addr only when respective
> addresses are specified in configuration.


Since we've had confirmation that the patch works, a much faster way
is to use sh's variable substitution magic, which also means a much
smaller change:

-            ip4.addr=\"${_addrl}\" ip6.addr=\"${_addr6l}\"
${_parameters} command=${_exec_start} > ${_tmp_jail} 2>&1 \
+            ${_addrl:+ip4.addr=\"${_addrl}\"}
${_addr6l:+ip6.addr=\"${_addr6l}\"} ${_parameters}
command=${_exec_start} > ${_tmp_jail} 2>&1 \

I'll get a patch together later

Chris