From owner-freebsd-current@FreeBSD.ORG  Sat Jul  3 16:29:32 2004
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 2956416A4CE
	for <current@freebsd.org>; Sat,  3 Jul 2004 16:29:32 +0000 (GMT)
Received: from bunrab.catwhisker.org
	(adsl-63-193-123-122.dsl.snfc21.pacbell.net [63.193.123.122])
	by mx1.FreeBSD.org (Postfix) with ESMTP id EA5B743D4C
	for <current@freebsd.org>; Sat,  3 Jul 2004 16:29:31 +0000 (GMT)
	(envelope-from david@catwhisker.org)
Received: from bunrab.catwhisker.org (localhost [127.0.0.1])
	i63GTVJM025673
	for <current@freebsd.org>; Sat, 3 Jul 2004 09:29:31 -0700 (PDT)
	(envelope-from david@bunrab.catwhisker.org)
Received: (from david@localhost)
	by bunrab.catwhisker.org (8.12.11/8.12.11/Submit) id i63GTVEo025672
	for current@freebsd.org; Sat, 3 Jul 2004 09:29:31 -0700 (PDT)
	(envelope-from david)
Date: Sat, 3 Jul 2004 09:29:31 -0700 (PDT)
From: David Wolfskill <david@catwhisker.org>
Message-Id: <200407031629.i63GTVEo025672@bunrab.catwhisker.org>
To: current@freebsd.org
In-Reply-To: <40E6D627.3030308@veldy.net>
Subject: Re: HEADSUP: Native preemption added to the kernel scheduler
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 03 Jul 2004 16:29:32 -0000

>Date: Sat, 03 Jul 2004 10:52:07 -0500
>From: "Thomas T. Veldhouse" <veldy@veldy.net>
>To: Steve Kargl <sgk@troutmask.apl.washington.edu>
>Cc: src-committers@freebsd.org
>Cc: current@freebsd.org
>Cc: cvs-src@freebsd.org
>Cc: cvs-all@freebsd.org
>Cc: Kris Kennaway <kris@obsecurity.org>
>Subject: Re: HEADSUP: Native preemption added to the kernel scheduler
>Sender: owner-freebsd-current@freebsd.org

[Recipient list trimmed a little....  :-}  dhw]

>Steve Kargl wrote:

>>--- sched_ule.c.orig    Sat Jul  3 07:51:02 2004
>>+++ sched_ule.c Sat Jul  3 07:51:15 2004
>>@@ -1716,7 +1716,7 @@
>>        kseq_load_rem(KSEQ_CPU(ke->ke_cpu), ke);
>>        kseq_notify(ke, cpu);
>>        /* When we return from mi_switch we'll be on the correct cpu. */
>>-       mi_switch(SW_VOL);
>>+       mi_switch(SW_VOL, NULL);
>> #endif
>> }


>No such problem.  I simply added NULL myself, by hand.  It compiles 
>fine, but the kernel panics on boot.

>Tom Veldhouse

I also added it by hand, but did not observe the panic:

freebeast(5.2-C)[1] uname -a
FreeBSD freebeast.catwhisker.org 5.2-CURRENT FreeBSD 5.2-CURRENT #6: Sat Jul  3 08:56:29 PDT 2004     root@freebeast.catwhisker.org:/common/S4/obj/usr/src/sys/FREEBEAST  i386
freebeast(5.2-C)[2] 

(This is on my SMP (2xPIII) machine.)

(And no, I didn't try compiling with -O2.)

Peace,
david
-- 
David H. Wolfskill				david@catwhisker.org
I do not "unsubscribe" from email "services" to which I have not explicitly
subscribed.  Rather, I block spammers' access to SMTP servers I control,
and encourage others who are in a position to do so to do likewise.