Date: Mon, 29 Aug 2016 14:52:54 -0400 From: Julio Merino <julio@meroh.net> To: Bryan Drewery <bdrewery@freebsd.org> Cc: "Ngie Cooper (yaneurabeya)" <yaneurabeya@gmail.com>, "freebsd-testing@freebsd.org" <freebsd-testing@freebsd.org>, Dimitry Andric <dim@freebsd.org>, "jenkins-admin@freebsd.org" <jenkins-admin@freebsd.org>, Li-Wen Hsu <lwhsu@freebsd.org> Subject: Re: Jenkins build is still unstable: FreeBSD_HEAD #564 Message-ID: <CADyfeQX-2FJgkGq061hEfK0bdas9dDxiP1M6toig7Xv6qT0ViQ@mail.gmail.com> In-Reply-To: <aea8f12f-5444-0211-1600-4f1f0216b555@FreeBSD.org> References: <1491374121.44.1472440150670.JavaMail.jenkins@jenkins-9.freebsd.org> <CFA236ED-7DE0-4BE1-B944-52284E2FB6E0@FreeBSD.org> <6E443BB8-0269-4812-A2F4-40AA303E69C6@FreeBSD.org> <CAG=rPVdfgoF0mts-edHATUaefD7YuGtNu5ZTJOa8efUn2W4QuA@mail.gmail.com> <8058052E-A09A-403E-828A-74B51ED4BBF4@FreeBSD.org> <20160829163911.GA51650@FreeBSD.cs.nctu.edu.tw> <E73154DF-6A88-457D-B1FF-6B7F7610C37F@FreeBSD.org> <4b8980f0-1a90-40d7-45b3-9569b321d1c6@FreeBSD.org> <20160829175247.GA10263@FreeBSD.cs.nctu.edu.tw> <CAA41D00-2451-42EC-B9FD-3E31F42F9CF6@gmail.com> <31f11ba3-ca29-0f85-f1c1-6a3cd467bb57@FreeBSD.org> <67E84707-3267-49F3-8DB6-13CBD05B1690@gmail.com> <B014DD06-4BB2-4503-8908-C78EFEE0FCA2@gmail.com> <3B60A57F-778C-4E7C-B081-098C0F6E92D2@gmail.com> <F144F428-A8B6-4E95-999E-D20B0A7B62C2@gmail.com> <5485945b-6539-5ed0-c089-5537d6bd70a9@FreeBSD.org> <C1275CD0-87F4-4EDF-8489-904CBCC7861A@gmail.com> <CADyfeQVGZeWAaXETakh%2BXwv%2BDs=%2B2WUUtK7krqDg-Wznb6JOew@mail.gmail.com> <aea8f12f-5444-0211-1600-4f1f0216b555@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Aug 29, 2016 at 2:45 PM, Bryan Drewery <bdrewery@freebsd.org> wrote= : > On 8/29/2016 11:38 AM, Julio Merino wrote: > > On Mon, Aug 29, 2016 at 2:28 PM, Ngie Cooper (yaneurabeya) > > <yaneurabeya@gmail.com <mailto:yaneurabeya@gmail.com>> wrote: > > > > > > > On Aug 29, 2016, at 11:20, Bryan Drewery <bdrewery@FreeBSD.org> > wrote: > > > > > > > Trust me, you're wasting your time, this is not the problem. If > it were > > > then _nothing_ would compile from the /usr/bin/cc compiler. It's > only a > > > problem with running the ATF tests which means it is likely > storing the > > > flags it is built with somewhere and reusing them. > > > > Then it=E2=80=99s potentially this variable (from lib/atf/libatf-c/= Makefile > ): > > > > CFLAGS+=3D -DATF_BUILD_CFLAGS=3D'"${_CFLAGS}=E2=80=9D=E2=80= =99 > > > > I=E2=80=99ll look through the Jenkins logs to confirm the CFLAGS th= at get > > passed in to lib/atf. > > > > > > Yes. If we ought to not use any of those flags at run-time (and we > > should not, as Bryan pointed out), then yes, the problem is in the > > setting of ATF_BUILD_CFLAGS et. al. > > Are there specific kinds of flags this is wanting to pickup and use > later? Such as -m or -f or -W? If we can limit to what is wanted and > safe it might be better. We can exclude > --sysroot/-isystem/-B/-L/-target as well but it isn't as trivial as it > seems since -isystem has a space after it. > This should mostly only pick -I, -L, and -Wl,-R flags to ensure the build action can find any needed dependencies, and it would be nice if it picked user-provided flags also. For atf in the base system, I *think* we could go with an empty set of flags (unless we have to do something special for private libraries). cc and c++ should just do the right thing without any flags to compile the simple things that the failing tests build. --=20 Julio Merino -- http://julio.meroh.net/
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CADyfeQX-2FJgkGq061hEfK0bdas9dDxiP1M6toig7Xv6qT0ViQ>