Date: Mon, 10 Dec 2012 15:51:07 -0800 From: Alfred Perlstein <bright@mu.org> To: Konstantin Belousov <kostikbel@gmail.com> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, Alfred Perlstein <alfred@freebsd.org>, src-committers@freebsd.org Subject: Re: svn commit: r244098 - head/sys/kern Message-ID: <50C6756B.80607@mu.org> In-Reply-To: <50C67272.4080008@mu.org> References: <201212102309.qBAN9uCf033959@svn.freebsd.org> <20121210231448.GX3013@kib.kiev.ua> <50C67272.4080008@mu.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 12/10/12 3:38 PM, Alfred Perlstein wrote: > On 12/10/12 3:14 PM, Konstantin Belousov wrote: >> On Mon, Dec 10, 2012 at 11:09:56PM +0000, Alfred Perlstein wrote: >>> Author: alfred >>> Date: Mon Dec 10 23:09:55 2012 >>> New Revision: 244098 >>> URL: http://svnweb.freebsd.org/changeset/base/244098 >>> >>> Log: >>> make sysctls kern.{bootfile,conftxt} read-only >> You just break installkernel. > My apologies, give me a few moments to double check this and I will > back out. So first off "installkernel" was not broken, the error is ignored by make, hence why I didn't see it. Second off, this is pretty broken, the first time you "installkernel" it gets it right, the second time it just seems to set kern.bootfile to /boot/kernel.old/kernel no even though that's not really the boot kernel. I will back out the change, but this just seems off. If we are going to change kern.bootfile, then we ought to detect when it's no longer valid at all and just zero it. or pretty much do something else. -Alfred
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?50C6756B.80607>