From owner-svn-src-all@freebsd.org  Thu Jun 14 12:49:48 2018
Return-Path: <owner-svn-src-all@freebsd.org>
Delivered-To: svn-src-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id E4D25100249D;
 Thu, 14 Jun 2018 12:49:47 +0000 (UTC)
 (envelope-from brde@optusnet.com.au)
Received: from mail108.syd.optusnet.com.au (mail108.syd.optusnet.com.au
 [211.29.132.59])
 by mx1.freebsd.org (Postfix) with ESMTP id 5630268D51;
 Thu, 14 Jun 2018 12:49:46 +0000 (UTC)
 (envelope-from brde@optusnet.com.au)
Received: from [192.168.0.102] (c110-21-101-228.carlnfd1.nsw.optusnet.com.au
 [110.21.101.228])
 by mail108.syd.optusnet.com.au (Postfix) with ESMTPS id 54C601A2410;
 Thu, 14 Jun 2018 22:49:44 +1000 (AEST)
Date: Thu, 14 Jun 2018 22:49:41 +1000 (EST)
From: Bruce Evans <brde@optusnet.com.au>
X-X-Sender: bde@besplex.bde.org
To: Eitan Adler <eadler@freebsd.org>
cc: Alexey Dokuchaev <danfe@freebsd.org>, Bruce Evans <brde@optusnet.com.au>, 
 svn-src-head@freebsd.org, svn-src-all@freebsd.org, 
 src-committers <src-committers@freebsd.org>
Subject: Re: svn commit: r333945 - head/usr.bin/top
In-Reply-To: <CAF6rxgkPZukK30c-eGWu3566ytTz7WUaVKSceog9tLs+AuEg8A@mail.gmail.com>
Message-ID: <20180614223558.S2349@besplex.bde.org>
References: <201805202319.w4KNJ9hj038452@repo.freebsd.org>
 <20180521094344.Q1053@besplex.bde.org> <20180521063953.GA70671@FreeBSD.org>
 <20180610122819.GA75055@FreeBSD.org>
 <CAF6rxgnvrsPRvL1dqFu6Pb6p8sszbzXEOaU6YHKZ5FCSn8g9hw@mail.gmail.com>
 <20180610162653.GA2999@FreeBSD.org>
 <CAF6rxgkPZukK30c-eGWu3566ytTz7WUaVKSceog9tLs+AuEg8A@mail.gmail.com>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
X-Optus-CM-Score: 0
X-Optus-CM-Analysis: v=2.2 cv=cIaQihWN c=1 sm=1 tr=0
 a=PalzARQSbocsUSjMRkwAPg==:117 a=PalzARQSbocsUSjMRkwAPg==:17
 a=kj9zAlcOel0A:10 a=6I5d2MoRAAAA:8 a=1n0M5KOwwqV-EO1I0TAA:9
 a=CjuIK1q_8ugA:10 a=IjZwj45LgO3ly-622nXo:22
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.26
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 14 Jun 2018 12:49:48 -0000

On Thu, 14 Jun 2018, Eitan Adler wrote:

> On 10 June 2018 at 09:26, Alexey Dokuchaev <danfe@freebsd.org> wrote:
>> On Sun, Jun 10, 2018 at 08:56:24AM -0700, Eitan Adler wrote:
>>> On 10 June 2018 at 05:28, Alexey Dokuchaev <danfe@freebsd.org> wrote:
>>>> I've just tried the latest top(1).  Now it's even worse:
>>>> ...
>>>> Also, it is COMMA now.  Can we please do something about this?  I am not
>>>> calling for "USER PRI" as Bruce had suggested, but "USERNAME PRI" is just
>>>> about right.
>>>
>>> FWIW I have not forgotten about this. I am planning on completely
>>> rewriting how the header, and data, get displayed so its low my
>>> priority (pun intended) list to fix this specific case until then.
>>
>> Great!  Looking forward to improvements.  top(1) should be neat(TM).
>> Take your time Eitan, it's not that urgent.
>
> What do y'all think of https://reviews.freebsd.org/D15801 ? It changes
> the username length to 8 unconditionally. Its rolled into a rewrite of
> how the header gets created in order to actually make it
> understandable.

Hard-coded 8 is too simple.  Old versions were easy enough to understand,
but that depends on them mostly being hard-coded.  I don't like to review
anything that is not in mail.

Bruce