From owner-svn-src-stable-8@FreeBSD.ORG  Tue Jan 15 15:29:29 2013
Return-Path: <owner-svn-src-stable-8@FreeBSD.ORG>
Delivered-To: svn-src-stable-8@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by hub.freebsd.org (Postfix) with ESMTP id B6A5D26C;
 Tue, 15 Jan 2013 15:29:29 +0000 (UTC)
 (envelope-from kevlo@FreeBSD.org)
Received: from svn.freebsd.org (svn.freebsd.org
 [IPv6:2001:1900:2254:2068::e6a:0])
 by mx1.freebsd.org (Postfix) with ESMTP id 9E582F87;
 Tue, 15 Jan 2013 15:29:29 +0000 (UTC)
Received: from svn.freebsd.org (svn.FreeBSD.org [8.8.178.70])
 by svn.freebsd.org (8.14.5/8.14.5) with ESMTP id r0FFTTTi074433;
 Tue, 15 Jan 2013 15:29:29 GMT (envelope-from kevlo@svn.freebsd.org)
Received: (from kevlo@localhost)
 by svn.freebsd.org (8.14.5/8.14.5/Submit) id r0FFTT8P074432;
 Tue, 15 Jan 2013 15:29:29 GMT (envelope-from kevlo@svn.freebsd.org)
Message-Id: <201301151529.r0FFTT8P074432@svn.freebsd.org>
From: Kevin Lo <kevlo@FreeBSD.org>
Date: Tue, 15 Jan 2013 15:29:29 +0000 (UTC)
To: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-stable@freebsd.org, svn-src-stable-8@freebsd.org
Subject: svn commit: r245460 - stable/8/sys/libkern
X-SVN-Group: stable-8
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-BeenThere: svn-src-stable-8@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SVN commit messages for only the 8-stable src tree
 <svn-src-stable-8.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-stable-8>, 
 <mailto:svn-src-stable-8-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-stable-8>
List-Post: <mailto:svn-src-stable-8@freebsd.org>
List-Help: <mailto:svn-src-stable-8-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-stable-8>, 
 <mailto:svn-src-stable-8-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 15 Jan 2013 15:29:29 -0000

Author: kevlo
Date: Tue Jan 15 15:29:28 2013
New Revision: 245460
URL: http://svnweb.freebsd.org/changeset/base/245460

Log:
  MFC r236899:
  
  Fix unloading of libiconv module.
  
  Previously it would either loop infinitely or exit with error leaking a lock.

Modified:
  stable/8/sys/libkern/iconv.c
Directory Properties:
  stable/8/sys/   (props changed)
  stable/8/sys/libkern/   (props changed)

Modified: stable/8/sys/libkern/iconv.c
==============================================================================
--- stable/8/sys/libkern/iconv.c	Tue Jan 15 14:35:35 2013	(r245459)
+++ stable/8/sys/libkern/iconv.c	Tue Jan 15 15:29:28 2013	(r245460)
@@ -90,9 +90,11 @@ iconv_mod_unload(void)
 	struct iconv_cspair *csp;
 
 	sx_xlock(&iconv_lock);
-	while ((csp = TAILQ_FIRST(&iconv_cslist)) != NULL) {
-		if (csp->cp_refcount)
+	TAILQ_FOREACH(csp, &iconv_cslist, cp_link) {
+		if (csp->cp_refcount) {
+			sx_xunlock(&iconv_lock);
 			return EBUSY;
+		}
 	}
 
 	while ((csp = TAILQ_FIRST(&iconv_cslist)) != NULL)