From owner-freebsd-ports-bugs@FreeBSD.ORG Wed Mar 14 19:10:01 2012 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id B4F771065670 for ; Wed, 14 Mar 2012 19:10:01 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 8EDD18FC16 for ; Wed, 14 Mar 2012 19:10:01 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q2EJA1Cg019624 for ; Wed, 14 Mar 2012 19:10:01 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q2EJA1XG019623; Wed, 14 Mar 2012 19:10:01 GMT (envelope-from gnats) Resent-Date: Wed, 14 Mar 2012 19:10:01 GMT Resent-Message-Id: <201203141910.q2EJA1XG019623@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Mel Flynn Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 68ED4106566B for ; Wed, 14 Mar 2012 19:02:22 +0000 (UTC) (envelope-from mel@datakitty.lan.rachie.is-a-geek.net) Received: from datakitty.lan.rachie.is-a-geek.net (rachie.is-a-geek.net [66.230.99.27]) by mx1.freebsd.org (Postfix) with ESMTP id 124298FC0A for ; Wed, 14 Mar 2012 19:02:21 +0000 (UTC) Received: from datakitty.lan.rachie.is-a-geek.net (localhost [127.0.0.1]) by datakitty.lan.rachie.is-a-geek.net (8.14.5/8.14.5) with ESMTP id q2EJ2Kga013185; Wed, 14 Mar 2012 11:02:20 -0800 (AKDT) (envelope-from mel@datakitty.lan.rachie.is-a-geek.net) Received: (from mel@localhost) by datakitty.lan.rachie.is-a-geek.net (8.14.5/8.14.5/Submit) id q2EJ2KqQ013177; Wed, 14 Mar 2012 11:02:20 -0800 (AKDT) (envelope-from mel) Message-Id: <201203141902.q2EJ2KqQ013177@datakitty.lan.rachie.is-a-geek.net> Date: Wed, 14 Mar 2012 11:02:20 -0800 (AKDT) From: Mel Flynn To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: MAINTAINER Subject: ports/166108: [patch] mail/qpopper: failing sendmail detection. X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Mel Flynn List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Mar 2012 19:10:01 -0000 >Number: 166108 >Category: ports >Synopsis: [patch] mail/qpopper: failing sendmail detection. >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Wed Mar 14 19:10:01 UTC 2012 >Closed-Date: >Last-Modified: >Originator: Mel Flynn >Release: FreeBSD 8.2-STABLE amd64 >Organization: >Environment: System: FreeBSD datakitty.lan.rachie.is-a-geek.net 8.2-STABLE FreeBSD 8.2-STABLE #6 r230977: Sun Feb 5 06:20:11 AKST 2012 mel@datakitty.lan.rachie.is-a-geek.net:/data/obj/data/RELENG_8/src/sys/GENERIC amd64 >Description: Qpopper's configure script tries to detect sendmail in a number of common paths, but the first guess will always fail, because sbindir contains an embedded shell variable. As a result, systems without base sendmail (more specifically, without /usr/sbin/sendmail) will fail configure step. Additional info: http://lists.freebsd.org/pipermail/freebsd-ports/2012-March/073828.html >How-To-Repeat: mv /usr/sbin/sendmail /usr/sbin/sendmail.off make -C /usr/ports/mail/qpopper clean configure >Fix: The fix attached preserves the old (incidental) behavior of prefering /usr/sbin/sendmail, but will also search $LOCALBASE/sbin/sendmail. People with sendmail not below LOCALBASE or any of the common search paths are left in the cold (but righfully so). --- qpopper.fix begins here --- Index: Makefile =================================================================== RCS file: /home/ncvs/ports/mail/qpopper/Makefile,v retrieving revision 1.104 diff -u -r1.104 Makefile --- Makefile 14 Feb 2012 10:59:49 -0000 1.104 +++ Makefile 14 Mar 2012 18:31:40 -0000 @@ -133,6 +133,9 @@ post-patch: @${RM} -f ${WRKSRC}/popper/md5.h @${REINPLACE_CMD} -e 's|%%PREFIX%%|${PREFIX}|g' ${WRKSRC}/man/* + @${REINPLACE_CMD} -e \ + 's|\$${sbindir}/sendmail|${LOCALBASE}/sbin/sendmail|g' \ + ${WRKSRC}/configure.in .if defined(WITH_POPPASSD) @${REINPLACE_CMD} -e 's|/usr/bin/smbpasswd|${LOCALBASE}/bin/smbpasswd|' \ ${WRKSRC}/password/poppassd.c Index: files/patch-configure.in =================================================================== RCS file: /home/ncvs/ports/mail/qpopper/files/patch-configure.in,v retrieving revision 1.2 diff -u -r1.2 patch-configure.in --- files/patch-configure.in 4 Dec 2003 23:46:57 -0000 1.2 +++ files/patch-configure.in 14 Mar 2012 18:47:09 -0000 @@ -1,10 +1,30 @@ ---- configure.in.orig Sat May 5 14:32:51 2001 -+++ configure.in Sat May 5 14:33:32 2001 -@@ -1257,7 +1257,6 @@ +--- configure.in.orig 2011-05-30 11:13:39.000000000 -0800 ++++ configure.in 2012-03-14 10:38:44.000000000 -0800 +@@ -1409,14 +1409,14 @@ + dnl + + AC_MSG_CHECKING([for sendmail program]) +-if test -f ${sbindir}/sendmail +-then +- AC_DEFINE(MAIL_COMMAND, "${sbindir}/sendmail") +- AC_MSG_RESULT([found at ${sbindir}/sendmail]) +-elif test -f /usr/sbin/sendmail ++if test -f /usr/sbin/sendmail + then + AC_DEFINE(MAIL_COMMAND, "/usr/sbin/sendmail") + AC_MSG_RESULT([found at /usr/sbin/sendmail]) ++elif test -f ${sbindir}/sendmail ++then ++ AC_DEFINE(MAIL_COMMAND, "${sbindir}/sendmail") ++ AC_MSG_RESULT([found at ${sbindir}/sendmail]) + elif test -f /usr/lib/sendmail + then + AC_DEFINE(MAIL_COMMAND, "/usr/lib/sendmail") +@@ -1508,7 +1508,6 @@ ) AC_CHECK_HEADER( ndbm.h, NDBM_H="yes"; AC_DEFINE(HAVE_NDBM_H), NDBM_H="no" ) -AC_CHECK_HEADER( gdbm.h, GDBM_H="yes"; AC_DEFINE(HAVE_GDBM_H), GDBM_H="no" ) AC_CHECK_HEADER( dbm.h, DBM_H="yes"; AC_DEFINE(HAVE_DBM_H), DBM_H="no" ) - + AC_CHECK_TYPES( socklen_t, , , [#include ] ) --- qpopper.fix ends here --- >Release-Note: >Audit-Trail: >Unformatted: