From owner-freebsd-bugs@FreeBSD.ORG  Thu Jan  2 06:50:01 2014
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@smarthost.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id DFA1851D
 for <freebsd-bugs@smarthost.ysv.freebsd.org>;
 Thu,  2 Jan 2014 06:50:01 +0000 (UTC)
Received: from freefall.freebsd.org (freefall.freebsd.org
 [IPv6:2001:1900:2254:206c::16:87])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id CA3001AA0
 for <freebsd-bugs@smarthost.ysv.freebsd.org>;
 Thu,  2 Jan 2014 06:50:01 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
 by freefall.freebsd.org (8.14.7/8.14.7) with ESMTP id s026o1bx064810
 for <freebsd-bugs@freefall.freebsd.org>; Thu, 2 Jan 2014 06:50:01 GMT
 (envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
 by freefall.freebsd.org (8.14.7/8.14.7/Submit) id s026o1J4064809;
 Thu, 2 Jan 2014 06:50:01 GMT (envelope-from gnats)
Date: Thu, 2 Jan 2014 06:50:01 GMT
Message-Id: <201401020650.s026o1J4064809@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.org
Cc: 
From: Peter Jeremy <peter@rulingia.com>
Subject: Re: kern/185395: IPv4 Multicast broken in 10.x
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.17
Precedence: list
Reply-To: Peter Jeremy <peter@rulingia.com>
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs/>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 02 Jan 2014 06:50:01 -0000

The following reply was made to PR kern/185395; it has been noted by GNATS.

From: Peter Jeremy <peter@rulingia.com>
To: Olivier =?iso-8859-1?Q?Cochard-Labb=E9?= <olivier@cochard.me>
Cc: freebsd-gnats-submit <FreeBSD-gnats-submit@freebsd.org>
Subject: Re: kern/185395: IPv4 Multicast broken in 10.x
Date: Thu, 2 Jan 2014 17:47:56 +1100

 --s9fJI615cBHmzTOP
 Content-Type: text/plain; charset=iso-8859-1
 Content-Disposition: inline
 Content-Transfer-Encoding: quoted-printable
 
 On 2014-Jan-01 22:03:36 +0100, Olivier Cochard-Labb=E9 <olivier@cochard.me>=
  wrote:
 >And what about the commit 249925 "Add const qualifier to the dst parameter
 >of the ifnet if_output method" (Fri Apr 26 12:50:32 2013 UTC) ?
 >
 >This commit modify function arpresolve() in sys/netinet/if_ether.c by
 >replacing:
 >arpresolve(...,struct sockaddr *dst, ...)
 >by
 >arpresolve(...,const struct sockaddr *dst, ...).
 >
 >And inside this function there is a call to this macro:
 >ETHER_MAP_IP_MULTICAST(&SIN(dst)->sin_addr, desten);
 
 ETHER_MAP_IP_MULTICAST does left to right assignment - the first argument is
 only read so this change doesn't affect anything.
 
 >=3D> If the 'structure dst' in now a 'const struct dst', can the struct 'd=
 st'
 >still be modified by the macro ??
 
 The macro never modified 'dst'.  In any case, the compiler tracks 'const'
 and would raise a compile-time error if something tried to modify dst.
 
 --=20
 Peter Jeremy
 
 --s9fJI615cBHmzTOP
 Content-Type: application/pgp-signature
 
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v2.0.22 (FreeBSD)
 
 iKYEARECAGYFAlLFC5xfFIAAAAAALgAoaXNzdWVyLWZwckBub3RhdGlvbnMub3Bl
 bnBncC5maWZ0aGhvcnNlbWFuLm5ldDBCRjc3QTcyNTg5NEVCRTY0RjREN0VFRUZF
 OEE0N0JGRjAwRkI4ODcACgkQ/opHv/APuIeGJQCgrnnT3SfB+/6uk0lDzXhIBjfm
 jOEAoL9KLPmZUm3vuTu+V4oUEkMoBysl
 =vVA+
 -----END PGP SIGNATURE-----
 
 --s9fJI615cBHmzTOP--