From owner-freebsd-scsi  Thu Dec 13 11:49:41 2001
Delivered-To: freebsd-scsi@freebsd.org
Received: from mail11.speakeasy.net (mail11.speakeasy.net [216.254.0.211])
	by hub.freebsd.org (Postfix) with ESMTP id 68C2F37B417
	for <scsi@FreeBSD.org>; Thu, 13 Dec 2001 11:49:33 -0800 (PST)
Received: (qmail 14021 invoked from network); 13 Dec 2001 19:49:31 -0000
Received: from unknown (HELO laptop.baldwin.cx) ([64.81.54.73]) (envelope-sender <jhb@FreeBSD.org>)
          by mail11.speakeasy.net (qmail-ldap-1.03) with SMTP
          for <scsi@FreeBSD.org>; 13 Dec 2001 19:49:31 -0000
Message-ID: <XFMail.011213114922.jhb@FreeBSD.org>
X-Mailer: XFMail 1.4.0 on FreeBSD
X-Priority: 3 (Normal)
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Date: Thu, 13 Dec 2001 11:49:22 -0800 (PST)
From: John Baldwin <jhb@FreeBSD.org>
To: scsi@FreeBSD.org
Subject: aic7xxx patch
Sender: owner-freebsd-scsi@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-scsi.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-scsi>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-scsi>
X-Loop: FreeBSD.org

gcc30 complains about using ++ on the same variable multiple times in a
statement since the value of the variable at each point is not defined.  This
is a simple patch to address this issue in hte aic7xxx driver:

Index: dev/aic7xxx/aic7xxx.c
===================================================================
RCS file: /usr/cvs/src/sys/dev/aic7xxx/aic7xxx.c,v
retrieving revision 1.79
diff -u -r1.79 aic7xxx.c
--- dev/aic7xxx/aic7xxx.c       17 Aug 2001 04:22:50 -0000      1.79
+++ dev/aic7xxx/aic7xxx.c       13 Dec 2001 19:41:32 -0000
@@ -1382,22 +1382,21 @@
               hscb->scsiid,
               hscb->lun,
               hscb->cdb_len);
-       i = 0;
        printf("Shared Data: %#02x %#02x %#02x %#02x\n",
-              hscb->shared_data.cdb[i++],
-              hscb->shared_data.cdb[i++],
-              hscb->shared_data.cdb[i++],
-              hscb->shared_data.cdb[i++]);
+              hscb->shared_data.cdb[0],
+              hscb->shared_data.cdb[1],
+              hscb->shared_data.cdb[2],
+              hscb->shared_data.cdb[3]);
        printf("             %#02x %#02x %#02x %#02x\n",
-              hscb->shared_data.cdb[i++],
-              hscb->shared_data.cdb[i++],
-              hscb->shared_data.cdb[i++],
-              hscb->shared_data.cdb[i++]);
+              hscb->shared_data.cdb[4],
+              hscb->shared_data.cdb[5],
+              hscb->shared_data.cdb[6],
+              hscb->shared_data.cdb[7]);
        printf("             %#02x %#02x %#02x %#02x\n",
-              hscb->shared_data.cdb[i++],
-              hscb->shared_data.cdb[i++],
-              hscb->shared_data.cdb[i++],
-              hscb->shared_data.cdb[i++]);
+              hscb->shared_data.cdb[8],
+              hscb->shared_data.cdb[9],
+              hscb->shared_data.cdb[10],
+              hscb->shared_data.cdb[11]);
        printf("        dataptr:%#x datacnt:%#x sgptr:%#x tag:%#x\n",
                ahc_le32toh(hscb->dataptr),
                ahc_le32toh(hscb->datacnt),


Any objections?

-- 

John Baldwin <jhb@FreeBSD.org>  <><  http://www.FreeBSD.org/~jhb/
"Power Users Use the Power to Serve!"  -  http://www.FreeBSD.org/

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-scsi" in the body of the message