From owner-freebsd-net  Wed Oct 23 23: 6:32 2002
Delivered-To: freebsd-net@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 19CCB37B407; Wed, 23 Oct 2002 23:06:31 -0700 (PDT)
Received: from out6.mx.nwbl.wi.voyager.net (out6.mx.nwbl.wi.voyager.net [169.207.3.77])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 8484743E42; Wed, 23 Oct 2002 23:06:30 -0700 (PDT)
	(envelope-from silby@silby.com)
Received: from [10.1.1.6] (d173.as12.nwbl0.wi.voyager.net [169.207.136.175])
	by out6.mx.nwbl.wi.voyager.net (Postfix) with ESMTP
	id A849DDABEF; Thu, 24 Oct 2002 01:06:28 -0500 (CDT)
Date: Thu, 24 Oct 2002 01:11:15 -0500 (CDT)
From: Mike Silbersack <silby@silby.com>
To: Bruce Evans <bde@zeta.org.au>
Cc: freebsd-net@FreeBSD.ORG, <jlemon@FreeBSD.ORG>,
	Harti Brandt <brandt@fokus.gmd.de>
Subject: Re: MII problem, need more eyes
In-Reply-To: <20021022174319.V13842-100000@gamplex.bde.org>
Message-ID: <20021023210943.W4698-100000@patrocles.silby.com>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: owner-freebsd-net@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-net.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-net>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-net>
X-Loop: FreeBSD.org


On Tue, 22 Oct 2002, Bruce Evans wrote:

> This return of 0 is apparently intentional.  The comment before this
> says:
>
> Here the "However" clause is not in RELENG_4.  Returning 0 gets the
> status updated.  I think this is just too expensive to do every second.
> Autonegotiation is only retried every 17 seconds (every 5 seconds in
> RELENG_4).

You're right, it looks like this is new functionality, not just code
refactoring.  I was hoping for a quick fix, and overlooked this.

There are two things I think that I can do to reduce the amount of time
taken up...

#1, Don't do the status update every second, only have it run every 10
seconds or so.

#2, Reduce the number of PHY operations.  mii_phy_tick reads the status
register, then nsphy_status rereads it basically immediately.  I'll have
to examine how the other phy drivers operate in this aspect.

Mike "Silby" Silbersack


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-net" in the body of the message