From owner-freebsd-arch@FreeBSD.ORG Tue Feb 16 19:59:29 2010 Return-Path: Delivered-To: arch@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E4CF4106566B; Tue, 16 Feb 2010 19:59:29 +0000 (UTC) (envelope-from asmrookie@gmail.com) Received: from mail-qy0-f189.google.com (mail-qy0-f189.google.com [209.85.221.189]) by mx1.freebsd.org (Postfix) with ESMTP id 7D6188FC16; Tue, 16 Feb 2010 19:59:29 +0000 (UTC) Received: by qyk27 with SMTP id 27so4185588qyk.3 for ; Tue, 16 Feb 2010 11:59:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:sender:received:in-reply-to :references:date:x-google-sender-auth:message-id:subject:from:to:cc :content-type:content-transfer-encoding; bh=D+j0hz46Eit6Apce7hy3JpD38lGu/3UyUGEd7+Rkh6U=; b=q6keUWQ1PyPEhn3qNXMKQhaaEk8nLIa+8GrllJAUKGA+q3RO02g9SwJPUORfjldTcG 8i3EGuWuBJCyYKwQNqTaja/yucz+JfNaF40+9xUQuazYQFz/t9JrS/YRQF1YFhGLji6I GbBnatxaGjSKyXHeL801sC8PMulLpmLl2c6hM= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; b=Ni2YpjHTqXCX2wVrImW0i/SqTIY9FZ1apy4cL43DFB8tQwjrRBQKL7NZtT91YmOU6Q LdKZ52PFXkk9ee+8P7xUSqIsIJidk6LkSS+mfBweLly7THFvckR2sf+S9qNqTmEpTyKL v5X2MNcOq1U5ybbltRap26/dHTxSnQEiLN2n0= MIME-Version: 1.0 Sender: asmrookie@gmail.com Received: by 10.231.168.132 with SMTP id u4mr2084889iby.79.1266350368311; Tue, 16 Feb 2010 11:59:28 -0800 (PST) In-Reply-To: <20100216185230.GA58974@sandvine.com> References: <3bbf2fe11002151610l41526f55r5e60b5e46ce42b64@mail.gmail.com> <20100216185230.GA58974@sandvine.com> Date: Tue, 16 Feb 2010 20:59:28 +0100 X-Google-Sender-Auth: e2e51f5c70d4d25f Message-ID: <3bbf2fe11002161159l4ef33f30i7bc8eb0c2dceb943@mail.gmail.com> From: Attilio Rao To: Ed Maste Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Cc: FreeBSD Arch Subject: Re: [PATCH] Adding shared code support for ia32 and amd64 -- x86 sub-branch X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Feb 2010 19:59:30 -0000 2010/2/16 Ed Maste : > On Tue, Feb 16, 2010 at 01:10:37AM +0100, Attilio Rao wrote: > >> The following patch: >> http://www.freebsd.org/~attilio/x86.diff >> >> starts the effort for having a shared sub-tree between amd64 and ia32. >> In this initial pass I putted the low-hanging fruits (bios/cpufreq) >> and what my customer was more interested in (isa/*) in order to >> kick-off the effort and, in the future, move gradually the code there. >> With the machine/isa/* cleanup about 10 files are trimmed and I'm sure >> more can be achieved easilly. >> There are few things to discuss. One, that I had not necessity to dig >> about still, is about how to organize headers (include/). Maybe some >> replication ala pc98 may be good. >> >> The patch is big but it is mostly added and removed files (look at the >> files.X in order to understand better how files movements happened). >> >> Hope to see comments and reviews. >> >> Attilio > > As you'd expect I'd be very happy to see this cleanup go ahead; having > essentially the same file duplicated in two places just adds maintenance > burden. > > Upon a quick review the patch looks OK to me. =C2=A0I assume we'll "svn m= v" > the i386 files into x86 and then add the amd64 diffs, thus maintaining > the history on the files in their new locations? Yes, that is what I did for generating the patch. Attilio --=20 Peace can only be achieved by understanding - A. Einstein