Date: Fri, 15 Nov 1996 23:30:36 +0800 From: Peter Wemm <peter@spinner.DIALix.COM> To: Bill Paul <wpaul@freefall.freebsd.org> Cc: CVS-committers@freefall.freebsd.org, bugs@freebsd.org Subject: Re: cvs commit: src/usr.sbin/rpc.yppasswdd yppasswd_comm.c Message-ID: <199611151530.XAA09855@spinner.DIALix.COM> In-Reply-To: Your message of "Fri, 15 Nov 1996 07:19:23 PST." <199611151519.HAA19794@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Bill Paul wrote: > > Modified: usr.sbin/rpc.yppasswdd yppasswd_comm.c > > Log: > > Uninitialised length variable passed to accept(), causing random accept() > > failures due to EFAULT. > > > > This is screaming out to go into 2.2 > > Dangit. That's the last time I hack without -Wall in my CFLAGS. I don't seem to recall seeing -Wall pick this up, but that may be because I have been working on several machines in parallel and may never have tried -Wall on a copy with the missing initialisation. > Am I to understand that this fixes both the problems you mentioned in > freebsd-bugs or is there still a problem with the shell strings getting > corrupted? No, this just fixes the chpass hang where yppasswdd aborted in the accept(). I'm getting kinda crazy about that one though, I smell a rat... > -Bill Cheers, -Peter
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199611151530.XAA09855>