From owner-svn-src-head@freebsd.org Sat Jun 23 16:56:37 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1E5D31027552; Sat, 23 Jun 2018 16:56:37 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from smtp-out-no.shaw.ca (smtp-out-no.shaw.ca [64.59.134.13]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4E3FD8A6AB; Sat, 23 Jun 2018 16:56:36 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from spqr.komquats.com ([70.67.125.17]) by shaw.ca with ESMTPA id Wlpqf4puK8PStWlprfJUh5; Sat, 23 Jun 2018 10:56:29 -0600 X-Authority-Analysis: v=2.3 cv=QP1GuDDL c=1 sm=1 tr=0 a=VFtTW3WuZNDh6VkGe7fA3g==:117 a=VFtTW3WuZNDh6VkGe7fA3g==:17 a=kj9zAlcOel0A:10 a=7mUfYlMuFuIA:10 a=6I5d2MoRAAAA:8 a=YxBL1-UpAAAA:8 a=jLMqdMmYszieh_CrYh4A:9 a=CjuIK1q_8ugA:10 a=IjZwj45LgO3ly-622nXo:22 a=Ia-lj3WSrqcvXOmTRaiG:22 Received: from slippy.cwsent.com (slippy [10.1.1.91]) by spqr.komquats.com (Postfix) with ESMTPS id 8881B24D; Sat, 23 Jun 2018 09:56:25 -0700 (PDT) Received: from slippy.cwsent.com (localhost [127.0.0.1]) by slippy.cwsent.com (8.15.2/8.15.2) with ESMTP id w5NGuPlf005396; Sat, 23 Jun 2018 09:56:25 -0700 (PDT) (envelope-from Cy.Schubert@cschubert.com) Received: from slippy (cy@localhost) by slippy.cwsent.com (8.15.2/8.15.2/Submit) with ESMTP id w5NGuPwm005393; Sat, 23 Jun 2018 09:56:25 -0700 (PDT) (envelope-from Cy.Schubert@cschubert.com) Message-Id: <201806231656.w5NGuPwm005393@slippy.cwsent.com> X-Authentication-Warning: slippy.cwsent.com: cy owned process doing -bs X-Mailer: exmh version 2.8.0 04/21/2012 with nmh-1.7.1 Reply-to: Cy Schubert From: Cy Schubert X-os: FreeBSD X-Sender: cy@cwsent.com X-URL: http://www.cschubert.com/ To: Alexey Dokuchaev cc: Eitan Adler , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r335547 - head/usr.bin/top In-Reply-To: Message from Alexey Dokuchaev of "Sat, 23 Jun 2018 16:16:56 -0000." <20180623161656.GB91517@FreeBSD.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Sat, 23 Jun 2018 09:56:25 -0700 X-CMAE-Envelope: MS4wfPNZYF46bpF+qYJMABkVKnxACFN1UYpJ+orH3xQScl6zvwmoUglxoguOYUxI01VtUxP5PqW7clpKdVgeKltBcNs0jDhobV+r+XnmYleKYs3/dAo8G51G IPQJmIWPxmrYjFY44Zk8ISyba8l1wVLH96EKCHtxrZR00Z3BSQcB4e1TV5S4kNJ6SvYeJryhdKWdvlmdpfewILdevLDWPKP6+N46yCnzsusI9J1yZKV5Zadv LklwVn7ayitE2VhUZ6LNJiTPod80hBT9+jGI2wpIPG1kcsnVzLzqlEH7oePvHKzJhizoAqpUCg0o+5DVr8A/PX8vvH8iajG3Sh5Vqq5hxeU= X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 23 Jun 2018 16:56:37 -0000 In message <20180623161656.GB91517@FreeBSD.org>, Alexey Dokuchaev writes: > On Fri, Jun 22, 2018 at 09:45:18AM +0000, Eitan Adler wrote: > > New Revision: 335547 > > URL: https://svnweb.freebsd.org/changeset/base/335547 > > > > Log: > > top(1): remove special handling of load > 5 > > > > ... > > Modified: head/usr.bin/top/screen.c > > =========================================================================== > === > > --- head/usr.bin/top/screen.c Fri Jun 22 09:41:13 2018 (r33554 > 6) > > +++ head/usr.bin/top/screen.c Fri Jun 22 09:45:18 2018 (r33554 > 7) > > @@ -55,7 +55,7 @@ static struct termios new_settings; > > static char is_a_terminal = false; > > > > void > > -init_termcap(int interactive) > > +init_termcap(bool interactive) > > { > > char *bufptr; > > char *PCptr; > > @@ -138,7 +138,7 @@ init_termcap(int interactive) > > /* get "ce", clear to end */ > > if (!overstrike) > > { > > - clear_line = tgetstr("ce", &bufptr); > > + clear_line = tgetstr("ce", &bufptr); > > } > > (I've seen it before, and replying to this commit as an example): would > you mind separating style and functional changes into different commits? > I know that top(1) is full of style bugs and it's very tempting to fix > them when you see them, but that's not really the best way to go. Agreed. My src commit bit mentor made sure I separated functional from style commits. Having been a prior ports committer, we on the ports side batch commits all the time but when glebius pointed this out to me I understood the reason why and I now try to do the same on the ports side of the fence too. It's more difficult it but IMO well worth it. I find that git helps separate these types of commits -- if I make a mistake it's easy enough to back out a git commit and do it again before git svn dcommit. Just my $0.02. -- Cheers, Cy Schubert FreeBSD UNIX: Web: http://www.FreeBSD.org The need of the many outweighs the greed of the few.