From nobody Fri Oct 27 17:33:48 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4SH8sT1wKHz4yVC9; Fri, 27 Oct 2023 17:33:49 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4SH8sT1RNjz3XqJ; Fri, 27 Oct 2023 17:33:49 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1698428029; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=VV/YHokPzRCkWCm8pr90k9VUexLxt9v9rxyyOx6eZVI=; b=qvdKVi7OmtmdN0Wht883/Cdn+50YyLrCv71DUx6myJNDz+sauQ2epVGSmYTxkMxzUpwc17 2cefd5BECaHEdcKbA/u4PoRkFkJ2GjuTDOpnqCxiTsf7f2mm52j3BUjbADLC+a82gFiVSI poFr2xF5dV88QnN3MggUUdZDuCw1h1QsmgNr5mdhKZSK+4fuzBQCE7sfcMqX07kvMo3Eld 366mOaoS49jTJrOSAB47dy+f4+nMLaHjy13WKybyu3nFzsgNYrB41nLDsyh9b7hXNzzayM zPvVoiVDj6MbE9bx/GhXuQYYSEE/TC+WXF4tyEGW6vdwLIyD9CdrwlRbovr+Jg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1698428029; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=VV/YHokPzRCkWCm8pr90k9VUexLxt9v9rxyyOx6eZVI=; b=oAKgkf1mMWSkiF/y6XzawD6lbuJvRuZ45VZJsip5x92017NlbGkGDoKMnG4lNg31RiqQcS qZ/ieaGnqYlsspQqcoAJd6j+uZkWTG30LMozb21HNjb5jLZGJl4FMUu6S/bG+z8VX50a+n uCHl5bBy3+J8B2fHlfBwDWtIISJChNvjkKy596ABYvhTuLWYtYqyocaPB4ae02i7w+gHFS 8H49zErXy2uAIQUGUuMnb5CCNsLrg0HpKf5AoxFSNnOLmoKfLPpsLBqy9suWDS5jaiiT0Q 0cZ9O3YhXYp8E4NKUjBVIVFHXHyFDSIVo8Nv45cXh10lUvWPTsRAdy86WPG8Jw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1698428029; a=rsa-sha256; cv=none; b=GH6+M0W5dosK/OWa5QyT/veF+oZ3JcHNnd1r59HFUtRgZSu2roToEYtckj8TJiqct9bmKU 1U0JEWtaEvof/Xk6G95VA+f7lKUyAVfUcL+jVUhjTSK/U86zs7tft20luG1DYTMrFMC5Q3 tKFcsabitYWkynylD5hvyDfGbXezBiU4TvSY3ScBimmYLqMUV4g0CiST1YH1yN53GG432r 8D2TtMxatWGfMUri48+02CAhl/3KS/f3Vo3GoQex2Klc/9dif8cA1S6nK21h1sQ6cW7Uv3 yVIITSyBsKiXizxLCpONSyAQG4spEFcCQLz5Mr1KG4Fibegx5HX9vaesqsqEdg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4SH8sT0Vv0z7mB; Fri, 27 Oct 2023 17:33:49 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 39RHXmJv092475; Fri, 27 Oct 2023 17:33:48 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 39RHXmI7092472; Fri, 27 Oct 2023 17:33:48 GMT (envelope-from git) Date: Fri, 27 Oct 2023 17:33:48 GMT Message-Id: <202310271733.39RHXmI7092472@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Mark Johnston Subject: git: ef161a35012f - stable/13 - bhyve: fix arguments to ioctl(VMIO_SIOCSIFFLAGS) List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/stable/13 X-Git-Reftype: branch X-Git-Commit: ef161a35012f187273dafc634751c5eb5db06092 Auto-Submitted: auto-generated The branch stable/13 has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=ef161a35012f187273dafc634751c5eb5db06092 commit ef161a35012f187273dafc634751c5eb5db06092 Author: Gleb Smirnoff AuthorDate: 2023-10-26 09:59:21 +0000 Commit: Mark Johnston CommitDate: 2023-10-27 17:33:34 +0000 bhyve: fix arguments to ioctl(VMIO_SIOCSIFFLAGS) ioctl(2)'s with integer argument shall pass command argument by value, not by pointer. The ioctl(2) manual page is not very clear about that. See sys/kern/sys_generic.c:sys_ioctl() near IOC_VOID. Reviewed by: markj Differential Revision: https://reviews.freebsd.org/D42366 Fixes: fd8b9c73a5a63a7aa438a73951d7a535b4f25d9a (cherry picked from commit f407a72a506d2630d60d9096c42058f12dff874e) --- usr.sbin/bhyve/net_backends.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/usr.sbin/bhyve/net_backends.c b/usr.sbin/bhyve/net_backends.c index 99781cfdcbb6..de6afab53854 100644 --- a/usr.sbin/bhyve/net_backends.c +++ b/usr.sbin/bhyve/net_backends.c @@ -238,7 +238,7 @@ tap_init(struct net_backend *be, const char *devname, goto error; } - if (ioctl(be->fd, VMIO_SIOCSIFFLAGS, &up)) { + if (ioctl(be->fd, VMIO_SIOCSIFFLAGS, up)) { WPRINTF(("tap device link up failed")); goto error; }