From owner-freebsd-current Tue May 23 22:44:30 2000 Delivered-To: freebsd-current@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 542) id 3020C37BBE7; Tue, 23 May 2000 22:44:26 -0700 (PDT) Date: Tue, 23 May 2000 22:44:26 -0700 From: "Andrey A. Chernov" To: Bruce Evans Cc: current@freebsd.org, jdp@freebsd.org Subject: Re: cvs commit: src/contrib/ncurses/include curses.h.in src/contrib/ncurses/ncurses/trace lib_trace.c Message-ID: <20000523224425.B26457@freebsd.org> References: <20000523085737.A27646@freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Mailer: Mutt 0.95.4i In-Reply-To: ; from bde@zeta.org.au on Wed, May 24, 2000 at 02:09:24PM +1000 Organization: Biomechanoid Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Wed, May 24, 2000 at 02:09:24PM +1000, Bruce Evans wrote: > > Previously it breaks system's /bin/sh so sh's trace() was wrongly renamed to > > sh_trace() instead of fixing ncurses. > > FYI, it may also break ftp, but the problem is only visible when ftp is linked > static, due to the problem with dynamic linkage in ld: > > /usr/src/usr.bin/ftp/cmds.c:906: warning: initialization makes integer from pointer without a cast > /usr/libexec/elf/ld: Warning: size of symbol `trace' changed from 4 to 5 in lib_trace.o > /usr/libexec/elf/ld: Warning: type of symbol `trace' changed from 1 to 2 in lib_trace.o Yes, this bug is very dangerous and many places are affected so I fix it immediately. The fact our ld can't detect multiply definitions when linking shared is another issue - I recently send this to -current, but still got no reaction. -- Andrey A. Chernov http://nagual.pp.ru/~ache/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message