From owner-freebsd-current@FreeBSD.ORG Thu Mar 13 19:38:03 2014 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 34234CB4; Thu, 13 Mar 2014 19:38:03 +0000 (UTC) Received: from bigwig.baldwin.cx (bigwig.baldwin.cx [IPv6:2001:470:1f11:75::1]) (using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 0C9A268F; Thu, 13 Mar 2014 19:38:03 +0000 (UTC) Received: from jhbbsd.localnet (unknown [209.249.190.124]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id 19B8AB94E; Thu, 13 Mar 2014 15:38:02 -0400 (EDT) From: John Baldwin To: freebsd-current@freebsd.org Subject: Re: vm_map.h Date: Thu, 13 Mar 2014 14:00:59 -0400 User-Agent: KMail/1.13.5 (FreeBSD/8.4-CBSD-20130906; KDE/4.5.5; amd64; ; ) References: In-Reply-To: MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Message-Id: <201403131400.59282.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (bigwig.baldwin.cx); Thu, 13 Mar 2014 15:38:02 -0400 (EDT) Cc: Bruno =?iso-8859-1?q?Lauz=E9?= , Alan Cox X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 13 Mar 2014 19:38:03 -0000 On Wednesday, March 12, 2014 5:13:28 pm Bruno Lauz=E9 wrote: > The two defines in vm/vm_map.h=20 >=20 > #define min_offset header.start /* (c) */ > #define max_offset header.end /* (c) */ >=20 >=20 > are really getting in the way because those words are most likely to be u= sed=20 downstream. >=20 > I would suggest renaming those defines to: >=20 > #define vm_min_offset header.start /* (c) */ > #define vm_max_offset header.end /* (c) */ >=20 > Am I missing something? A simpler fix is probably to put the #define's under #ifdef _KERNEL. =2D-=20 John Baldwin