From owner-freebsd-bugs@freebsd.org Wed Jul 20 21:58:52 2016 Return-Path: Delivered-To: freebsd-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 531E8B9F85A for ; Wed, 20 Jul 2016 21:58:52 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 273031703 for ; Wed, 20 Jul 2016 21:58:52 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id u6KLwp7T008277 for ; Wed, 20 Jul 2016 21:58:52 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-bugs@FreeBSD.org Subject: [Bug 211195] pw userdel Segmentation fault (core dumped) Date: Wed, 20 Jul 2016 21:58:51 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bin X-Bugzilla-Version: 10.3-STABLE X-Bugzilla-Keywords: regression X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: ryan@ryanday.net X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc attachments.created Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Jul 2016 21:58:52 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D211195 rday changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ryan@ryanday.net --- Comment #3 from rday --- Created attachment 172760 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D172760&action= =3Dedit Patch for 211195 The crash occurs in the rm_r() function, however the core dump issue looks a little more subtle than not having a home directory. For example, the comma= nds # pw user add someuser -g somegroup -d "/home/someuser" -s "/usr/sbin/nolog= in" # pw user del someuser -r Won't core dump. /home/someuser doesn't exist, and the problematic code nev= er runs. In your example the home directory was "/dev/null", which *does* exist even though -m wasn't specified. The program uses openat(2) with the O_DIRECTORY flag to open "/dev/null" which is not a directory. openat() returns an unchecked error, and the program crashes when it tries to open the invalid descriptor. I was able to reproduce this in the master branch on the Github repo. I attached a patch for the rm_r() function to check the return value of opena= t(). It looks like openat()'s return value isn't checked in a couple other locat= ions in the code as well. Those code paths may not be accessible though. --=20 You are receiving this mail because: You are the assignee for the bug.=