Date: Fri, 22 May 2015 09:45:40 +0200 From: Mathieu Arnold <mat@FreeBSD.org> To: Jan Beich <jbeich@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r386990 - head/audio/xcdplayer/files Message-ID: <58EBCBEF789BD5DB8E743507@atuin.in.mat.cc> In-Reply-To: <201505220730.t4M7Up3P046980@svn.freebsd.org> References: <201505220730.t4M7Up3P046980@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
+--On 22 mai 2015 07:30:51 +0000 Jan Beich <jbeich@FreeBSD.org> wrote: | Author: jbeich | Date: Fri May 22 07:30:50 2015 | New Revision: 386990 | URL: https://svnweb.freebsd.org/changeset/ports/386990 | | Log: | audio/xcdplayer: oops, svn:keywords vs. fbsd:nokeywords | | Modified: | Directory Properties: | head/audio/xcdplayer/files/patch-internals.c (props changed) No, please, do not, ever, add $FreeBSD$ keywords to patches, even more, do *not* remove fbsd:nokeywords. See 4.2.2 of the porter's handbook[1]. I spent a good long time removing all of them, do not add some back. 1: <https://www.freebsd.org/doc/en/books/porters-handbook/slow-patch.html>; -- Mathieu Arnold
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?58EBCBEF789BD5DB8E743507>