From owner-freebsd-stable@FreeBSD.ORG Thu May 24 22:46:59 2012 Return-Path: Delivered-To: freebsd-stable@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id BA841106566B for ; Thu, 24 May 2012 22:46:59 +0000 (UTC) (envelope-from jamie@FreeBSD.org) Received: from m2.gritton.org (gritton.org [199.192.164.235]) by mx1.freebsd.org (Postfix) with ESMTP id 6A63F8FC0A for ; Thu, 24 May 2012 22:46:59 +0000 (UTC) Received: from guppy.corp.verio.net (fw.oremut02.us.wh.verio.net [198.65.168.24]) (authenticated bits=0) by m2.gritton.org (8.14.5/8.14.5) with ESMTP id q4OMkvjB071058; Thu, 24 May 2012 16:46:57 -0600 (MDT) (envelope-from jamie@FreeBSD.org) Message-ID: <4FBEBA5C.7050804@FreeBSD.org> Date: Thu, 24 May 2012 16:46:52 -0600 From: Jamie Gritton User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:9.0) Gecko/20120126 Thunderbird/9.0 MIME-Version: 1.0 To: Mateusz Guzik References: <1337887134.1908.20.camel@mike-PC> <20120524212219.GA17579@dft-labs.eu> <1337897210.1908.24.camel@mike-PC> <20120524221353.GB17579@dft-labs.eu> <1337898015.1908.27.camel@mike-PC> <20120524223004.GC17579@dft-labs.eu> In-Reply-To: <20120524223004.GC17579@dft-labs.eu> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: Mike Jakubik , "freebsd-stable@freebsd.org" Subject: Re: Jail startup/shutdown broken on latest 9-STABLE X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 May 2012 22:46:59 -0000 On 05/24/12 16:30, Mateusz Guzik wrote: > On Thu, May 24, 2012 at 06:20:15PM -0400, Mike Jakubik wrote: >> On Fri, 2012-05-25 at 00:13 +0200, Mateusz Guzik wrote: >>> On Thu, May 24, 2012 at 06:06:50PM -0400, Mike Jakubik wrote: >>>> On Thu, 2012-05-24 at 23:22 +0200, Mateusz Guzik wrote: >>>>> On Thu, May 24, 2012 at 03:18:54PM -0400, Mike Jakubik wrote: >>>>>> Hello, >>>>>> >>>>>> Latest 9-STABLE has introduced some changes that break the ezjail rc >>>>>> script. On bootup it fails to start, but when i log in via ssh and >>>>>> manually start it, it works. However i am unable to shut them down >>>>>> afterwards. >>>>>> >>>>> Try this: >>>>> http://student.agh.edu.pl/~mjguzik/patches/jail-startup-shutdown.patch >>>>> >>>>> cd /usr/src&& patch -p1< patch&& cd usr.sbin/jail&& make&& make install >>>>> >>>>> /usr/src/etc/rc.d/jail script can be just copied over. >>>>> >>>>> Note that your /var/run/jail_* files have broken content (some line from >>>>> /etc/rc's output instead of jail id). >>>>> >>>> >>>> Mateusz, >>>> >>>> Thanks for the patch, it fixes the startup issue on boot, however >>>> shutting down the jails still does not work. The /var/run files have >>>> garbage in them as you mentioned. >>>> >>>> root@jail.local:~# cat /var/run/jail_app.id >>>> /etc/rc: WARNING: $hostname is not set -- see rc.conf(5). >>>> >>>> >>>> Hostname is set in /etc/rc.conf. >>> >>> This message is about rc.conf from your jail. >>> >>> This should be fixed by my change to etc/rc.d/jail, are you sure that >>> you are running patched version? >>> >> >> Right, i just realized this. I set the hostname in the jailed rc.conf, >> now the file contains this: >> >> root@jail.local:~# cat /var/run/jail_app.id >> Setting hostname: app.local. >> >> I do not see a link to your jail rc.d script, just the patch. >> >> > > Patch contains two fixes, for both usr/sbin/jail and etc/rc.d/jail. > > Assuming that the patch is still applied to your source tree, just do: > cp /usr/src/etc/rc.d/jail /etc/rc.d/jail > > This fixes the jail script to actually store jail id instead of messages > from /etc/rc. > > That is, you should be able to stop jails started by new etc/rc.d/jail > script. I'll get the patch to jail(8) in - thanks for catching that. But I wonder about the patch to /etc/rc.d/jail. It looks correct, but I'm going to see if it's /etc/rc.d/jail that needs changing, or if my recent changes to jail(8) have changed the order in which things are written. - Jamie