Date: Wed, 14 Oct 2020 13:24:32 -0300 From: Renato Botelho <garga@FreeBSD.org> To: Mathieu Arnold <mat@freebsd.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r552232 - head/devel/git Message-ID: <08277fd7-c7fe-e075-604f-bc5551626c7a@FreeBSD.org> In-Reply-To: <20201014115047.omi53rjydfvoabyk@aching.in.mat.cc> References: <202010131132.09DBWRIZ099906@repo.freebsd.org> <20201014115047.omi53rjydfvoabyk@aching.in.mat.cc>
next in thread | previous in thread | raw e-mail | index | archive | help
On 14/10/20 08:50, Mathieu Arnold wrote: > On Tue, Oct 13, 2020 at 11:32:27AM +0000, Renato Botelho wrote: >> Author: garga >> Date: Tue Oct 13 11:32:26 2020 >> New Revision: 552232 >> URL: https://svnweb.freebsd.org/changeset/ports/552232 >> >> Log: >> Simplify logic to define COMMENT >> >> Submitted by: bapt >> >> Modified: >> head/devel/git/Makefile >> >> Modified: head/devel/git/Makefile >> ============================================================================== >> --- head/devel/git/Makefile Tue Oct 13 11:30:50 2020 (r552231) >> +++ head/devel/git/Makefile Tue Oct 13 11:32:26 2020 (r552232) >> @@ -12,12 +12,11 @@ EXTRACT_ONLY= ${DISTNAME}${EXTRACT_SUFX} \ >> ${PORTNAME}-manpages-${DISTVERSION}${EXTRACT_SUFX} >> >> MAINTAINER= garga@FreeBSD.org >> -.if ${FLAVOR:Udefault} == default >> COMMENT= Distributed source code management tool >> -.elif ${FLAVOR:U} == gui >> -COMMENT= Distributed source code management tool (GUI enabled flavor) >> +.if ${FLAVOR:U} == gui >> +COMMENT+= (GUI enabled flavor) >> .elif ${FLAVOR:U} == lite >> -COMMENT= Distributed source code management tool (lite flavor) >> +COMMENT+= (lite flavor) >> .endif > > If one really wanted to make it clear and simple, one could even write: > > COMMENT= Distributed source code management tool ${COMMENT_${FLAVOR}} > COMMENT_gui= (GUI enabled flavor) > COMMENT_lite= (lite flavor) Really nice! I'm going to change it. Thanks! -- Renato Botelho
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?08277fd7-c7fe-e075-604f-bc5551626c7a>