From owner-cvs-all@FreeBSD.ORG Fri Mar 26 10:27:17 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7AEE516A4CE; Fri, 26 Mar 2004 10:27:17 -0800 (PST) Received: from smtp1.server.rpi.edu (smtp1.server.rpi.edu [128.113.2.1]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2448343D1D; Fri, 26 Mar 2004 10:27:17 -0800 (PST) (envelope-from gad@FreeBSD.org) Received: from [128.113.24.47] (gilead.netel.rpi.edu [128.113.24.47]) by smtp1.server.rpi.edu (8.12.8/8.12.8) with ESMTP id i2QIRGtO015753; Fri, 26 Mar 2004 13:27:16 -0500 Mime-Version: 1.0 X-Sender: gad@gilead.netel.rpi.edu (Unverified) Message-Id: In-Reply-To: References: Date: Fri, 26 Mar 2004 13:27:15 -0500 To: Robert Watson From: Garance A Drosehn Content-Type: text/plain; charset="us-ascii" ; format="flowed" X-Scanned-By: CanIt (www . canit . ca) cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.bin/pkill pkill.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Mar 2004 18:27:17 -0000 At 1:11 PM -0500 3/26/04, Robert Watson wrote: >On Fri, 26 Mar 2004, Garance A Drosehn wrote: > >> Modified files: >> usr.bin/pkill pkill.c >> Log: > > Switch to checking P_KTHREAD instead of P_SYSTEM when > > deciding what "system processes" to always ignore. > >Either our definition or my understanding of P_KTHREAD vs >P_SYSTEM is weak. P_SYSTEM seems to include init, and >P_KTHREAD seems to mean things that really are kprocs, but >there was some recent discussion of the details of this on >arch@ with regard to whether signals should be delivered to >things that are arguably kernel threads or processes. It would not surprise me if P_KTHREAD is not the most correct check for me to make here, but in my debugging it sure seems like using P_SYSTEM results in some processes getting skipped that I do not expect to be skipped. -- Garance Alistair Drosehn = gad@gilead.netel.rpi.edu Senior Systems Programmer or gad@FreeBSD.org Rensselaer Polytechnic Institute; Troy, NY; USA