Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 5 Oct 2012 06:39:20 -0700
From:      Luigi Rizzo <rizzo@iet.unipi.it>
To:        Gleb Smirnoff <glebius@freebsd.org>
Cc:        Ermal Lu?i <eri@freebsd.org>, net@freebsd.org
Subject:   Re: [PATCH] resolve byte order mess in ip_input/ip_output/pfil(9)
Message-ID:  <CA%2BhQ2%2BiEfLzpUFdv%2Bo3xURcp0jy_5XSD9reDFJUC2p_wux39Nw@mail.gmail.com>
In-Reply-To: <20121005131228.GQ34622@glebius.int.ru>
References:  <20121005114716.GP34622@FreeBSD.org> <CAPBZQG0Z0Hc-DCQoyZGEwLMXB4wSsEZhyoy9zNDuXe8P8LBoQA@mail.gmail.com> <20121005131228.GQ34622@glebius.int.ru>

next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Oct 5, 2012 at 6:12 AM, Gleb Smirnoff <glebius@freebsd.org> wrote:

>   Ermal,
>
> On Fri, Oct 05, 2012 at 03:01:38PM +0200, Ermal Lu?i wrote:
> E> it would be better to switch to net byte order allover rather than
> E> trade one for the other.
> E> This makes it even more tricky to understand the code than it is.
> E> If you do the work its better to do the full thing in one shot and
> E> switch to netbyte order.
>
> Please read carefully my description and patch. It creates a definite
> points in stack where byte order is swapped. One point where it is
> swapped into host, and one point where it is swapped back into net.
>
> Patch already narrows down the scope of host byte order in the stack,
> host byte order is now between to definite points. If anyone ever wants
> to switch entire stack to net byte order, let it be. Current patch is
> just step in this direction.
>

Good. I too wanted to be sure that the change is a step towards
"everything in NET order" even though nobody expects you to do
it all at once.

(having everything in the same byte order is obviously useful because
one does not need to deal with the differences, but having everything
in wire format is even more interesting because it eventually makes
buffers readonly).

cheers
luigi



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CA%2BhQ2%2BiEfLzpUFdv%2Bo3xURcp0jy_5XSD9reDFJUC2p_wux39Nw>