From owner-svn-src-all@freebsd.org Thu Nov 21 21:11:29 2019 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id AACD81CAFDE; Thu, 21 Nov 2019 21:11:29 +0000 (UTC) (envelope-from brooks@spindle.one-eyed-alien.net) Received: from spindle.one-eyed-alien.net (spindle.one-eyed-alien.net [199.48.129.229]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 47JsgN6Hydz3xHy; Thu, 21 Nov 2019 21:11:28 +0000 (UTC) (envelope-from brooks@spindle.one-eyed-alien.net) Received: by spindle.one-eyed-alien.net (Postfix, from userid 3001) id DC0EB3C0199; Thu, 21 Nov 2019 21:11:27 +0000 (UTC) Date: Thu, 21 Nov 2019 21:11:27 +0000 From: Brooks Davis To: Glen Barber Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org, FreeBSD Ports Management Team , Colin Percival Subject: Re: svn commit: r354909 - in head: . share/mk Message-ID: <20191121211127.GC50024@spindle.one-eyed-alien.net> References: <201911201836.xAKIawWt053874@repo.freebsd.org> <20191121161337.GA92849@FreeBSD.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="dc+cDN39EJAMEtIO" Content-Disposition: inline In-Reply-To: <20191121161337.GA92849@FreeBSD.org> User-Agent: Mutt/1.9.4 (2018-02-28) X-Rspamd-Queue-Id: 47JsgN6Hydz3xHy X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=none (mx1.freebsd.org: domain of brooks@spindle.one-eyed-alien.net has no SPF policy when checking 199.48.129.229) smtp.mailfrom=brooks@spindle.one-eyed-alien.net X-Spamd-Result: default: False [-6.50 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-0.99)[-0.992,0]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-0.997,0]; MIME_GOOD(-0.20)[multipart/signed,text/plain]; DMARC_NA(0.00)[freebsd.org]; AUTH_NA(1.00)[]; RCPT_COUNT_FIVE(0.00)[6]; IP_SCORE(-3.61)[ip: (-9.46), ipnet: 199.48.128.0/22(-4.72), asn: 36236(-3.85), country: US(-0.05)]; R_SPF_NA(0.00)[]; SIGNED_PGP(-2.00)[]; FORGED_SENDER(0.30)[brooks@freebsd.org,brooks@spindle.one-eyed-alien.net]; RCVD_COUNT_ZERO(0.00)[0]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; ASN(0.00)[asn:36236, ipnet:199.48.128.0/22, country:US]; FROM_NEQ_ENVFROM(0.00)[brooks@freebsd.org,brooks@spindle.one-eyed-alien.net] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Nov 2019 21:11:29 -0000 --dc+cDN39EJAMEtIO Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Nov 21, 2019 at 04:13:37PM +0000, Glen Barber wrote: > On Wed, Nov 20, 2019 at 06:36:58PM +0000, Brooks Davis wrote: > > Author: brooks > > Date: Wed Nov 20 18:36:58 2019 > > New Revision: 354909 > > URL: https://svnweb.freebsd.org/changeset/base/354909 > >=20 > > Log: > > Make the warning for deprecated NO_ variables an error. > > =20 > > Support for NO_CTF, NO_DEBUG_FILES, NO_INSTALLLIB, NO_MAN, NO_PROFILE, > > and NO_WARNS as deprecated in 2014 with a warning added for each one > > found. Turn these into error in preperation for removal of compatabil= ity > > support before FreeBSD 13. > > =20 > > Reviewed by: imp > > Relnotes: yes > > Sponsored by: DARPA, AFRL > > Differential Revision: https://reviews.freebsd.org/D22448 > >=20 >=20 > > Modified: head/share/mk/bsd.opts.mk > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D > > --- head/share/mk/bsd.opts.mk Wed Nov 20 18:12:01 2019 (r354908) > > +++ head/share/mk/bsd.opts.mk Wed Nov 20 18:36:58 2019 (r354909) > > @@ -100,7 +100,7 @@ __DEFAULT_DEPENDENT_OPTIONS =3D \ > > PROFILE \ > > WARNS > > .if defined(NO_${var}) > > -.warning "NO_${var} is defined, but deprecated. Please use MK_${var}= =3Dno instead." > > +.error "NO_${var} is defined, but deprecated. Please use MK_${var}=3Dn= o instead." > > MK_${var}:=3Dno > > .endif > > .endfor > >=20 >=20 > Had this been exp-run tested? This breaks at least the > net/bsdec2-image-upload port, which does *not* set NO_MAN explicitly in > its Makefile. I suspect at least several other ports are now implicitly > broken as result of this change. No, it wasn't. I didn't realize it was needed. I could revert if there's significant fallout. I've patched net/bsdec2-image-upload and I'm testing a patch for emulators/open-vm-tools. In general the issue is people putting NO_MAN=3D in Makefiles that the freebsd build infrastructure and then never looking at build output. In some cases it's clearly blind copy-and-paste (e.g. emulators/open-vm-tools sets NO_MAN and NOMAN in a kmod Makefile where they do nothing). Ideally I'd like to suppress these errors in ports unless DEVELOPER is defined, but I'm not sure how best to do that. -- Brooks --dc+cDN39EJAMEtIO Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEcBAEBAgAGBQJd1v1/AAoJEKzQXbSebgfAGcMH/16GvoPgZCr65wRJ8bMeAmcV XL1PNd2kP7h/J6dPeWWVAEOh26FspYBzhu93hMDd1qcNqiHHT3HzDvsLaTaR+YJQ kyL9KytRC+XzFad5YgW0Q403u+P88jgQtllHvJm++Z79Rj732B18gKrggEnfTfUu 8MAb8jgaGRXrmaKCtbmHfeloiz2FPBXJh7mlG5Gf8sWonvKF6rzEfc4yRI04JnSn CNFIqeG6CGld0DP15oYNGzTdYvZC7kkF7DvFfKn0ilaquu4D22JF5he1KHG9JdxA 4/+tmw+xvRDTJKOg32YQr5Sc5NHFwW/tUIE97V4QQ441P68zcStd764791LdRu8= =wzRv -----END PGP SIGNATURE----- --dc+cDN39EJAMEtIO--