From owner-freebsd-usb@FreeBSD.ORG  Tue Sep 22 16:38:06 2009
Return-Path: <owner-freebsd-usb@FreeBSD.ORG>
Delivered-To: freebsd-usb@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 18C7F1065670
	for <freebsd-usb@freebsd.org>; Tue, 22 Sep 2009 16:38:06 +0000 (UTC)
	(envelope-from hselasky@c2i.net)
Received: from swip.net (mailfe13.swip.net [212.247.155.129])
	by mx1.freebsd.org (Postfix) with ESMTP id 9CE358FC18
	for <freebsd-usb@freebsd.org>; Tue, 22 Sep 2009 16:38:05 +0000 (UTC)
X-Cloudmark-Score: 0.000000 []
X-Cloudmark-Analysis: v=1.0 c=1 a=MnI1ikcADjEx7bvsp0jZvQ==:17
	a=ZsU00AtvC4qczHK_PhMA:9 a=b8DmBnQgBDWjI3E6FIeHLvlp8wUA:4
	a=p6-se_fFCm7sBxGW:21 a=hoH4u6ILCsGuHcb_:21
Received: from [188.126.201.140] (account mc467741@c2i.net HELO
	laptop.adsl.tele2.no)
	by mailfe13.swip.net (CommuniGate Pro SMTP 5.2.16)
	with ESMTPA id 922014458; Tue, 22 Sep 2009 18:38:02 +0200
From: Hans Petter Selasky <hselasky@c2i.net>
To: freebsd-usb@freebsd.org
Date: Tue, 22 Sep 2009 18:38:41 +0200
User-Agent: KMail/1.11.4 (FreeBSD/9.0-CURRENT; KDE/4.2.4; i386; ; )
References: <2C0D6269-1296-4D34-8029-828A0FE281CB@tlb.org>
	<200909221740.49279.hselasky@c2i.net>
In-Reply-To: <200909221740.49279.hselasky@c2i.net>
X-Face: (%<A9p'; 5>:6u[ldzJ`0qjD7sCkfdMmD*RxpO<Q0yAl~?`'F?jDVb]E6TQ7'#h-VlLs}k/
	(yxg(p!IL.`#ng"%`BMrham7%UK,}VH\wUOm=^>wEEQ+KWt[{J#x6ow~JO:,zwp.(t; @Aq
	:4:&nFCgDb8[3oIeTb^'",;u{5{}C9>"PuY\)!=#\u9SSM-nz8+SR~B\!qBv
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200909221838.42182.hselasky@c2i.net>
Cc: 
Subject: Re: libusb20 api
X-BeenThere: freebsd-usb@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: FreeBSD support for USB <freebsd-usb.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-usb>,
	<mailto:freebsd-usb-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-usb>
List-Post: <mailto:freebsd-usb@freebsd.org>
List-Help: <mailto:freebsd-usb-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-usb>,
	<mailto:freebsd-usb-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 22 Sep 2009 16:38:06 -0000

On Tuesday 22 September 2009 17:40:48 Hans Petter Selasky wrote:
> On Tuesday 22 September 2009 00:38:46 Trevor Blackwell wrote:
> > This always fails:
> >
> >        char devname[256];
> >        if (libusb20_dev_get_iface_desc(pdev, n, devname,
> > sizeof(devname))) break;
> >
> > while this works:
> >
> >        char devname[128];
> >        if (libusb20_dev_get_iface_desc(pdev, n, devname,
> > sizeof(devname))) break;
> >
> > Because this function takes a uint8_t for length:
> >
> > <libusb20_ugen20.c:851>:
> > static int
> > ugen20_dev_get_iface_desc(struct libusb20_device *pdev,
> >      uint8_t iface_index, char *buf, uint8_t len)
> >
> > even though the kernel ioctl structure has a 16-bit length.
> >
> > Hans, why not just use size_t for such arguments?
>
> Your point is valid. Currently USB string descriptors are always limited to
> 255 bytes. Setting up a larger buffer does not make sense.
>
> I will see what I can do.
>

s/string/interface/

> --HPS