Date: Sat, 1 May 1999 19:09:34 -0500 (CDT) From: nectar@nectar.com To: FreeBSD-gnats-submit@freebsd.org Subject: bin/11433: dump munges device names greater than 16 bytes in /etc/dumpdates Message-ID: <19990502000934.2BFFC1DC5@spawn.nectar.com>
next in thread | raw e-mail | index | archive | help
>Number: 11433 >Category: bin >Synopsis: dump munges device names greater than 16 bytes in /etc/dumpdates >Confidential: yes >Severity: serious >Priority: high >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Sat May 1 17:20:00 PDT 1999 >Closed-Date: >Last-Modified: >Originator: Jacques Vidrine >Release: FreeBSD 3.1-STABLE i386 >Organization: None >Environment: All versions of FreeBSD >Description: When reading or updating /etc/dumpdates, dump will truncate device names (the first column) longer than 16 bytes. This was discovered while dumping vinum volumes, which may have long names such as /dev/vinum/rpackages. >How-To-Repeat: ``dump -u'' with a device that has a name longer than 16 bytes. >Fix: Increasing the size to 32 bytes was sufficient for this site. Index: dumprestore.h =================================================================== RCS file: /home/ncvs/src/include/protocols/dumprestore.h,v retrieving revision 1.5 diff -u -u -r1.5 dumprestore.h --- dumprestore.h 1998/10/27 04:01:19 1.5 +++ dumprestore.h 1999/05/01 23:57:45 @@ -105,8 +105,8 @@ #define DR_NEWHEADER 0x0001 /* new format tape header */ #define DR_NEWINODEFMT 0x0002 /* new format inodes on tape */ -#define DUMPOUTFMT "%-16s %c %s" /* for printf */ +#define DUMPOUTFMT "%-32s %c %s" /* for printf */ /* name, level, ctime(date) */ -#define DUMPINFMT "%16s %c %[^\n]\n" /* inverse for scanf */ +#define DUMPINFMT "%32s %c %[^\n]\n" /* inverse for scanf */ #endif /* !_DUMPRESTORE_H_ */ >Release-Note: >Audit-Trail: >Unformatted: To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?19990502000934.2BFFC1DC5>