From owner-cvs-src@FreeBSD.ORG Tue Apr 24 09:19:13 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 935CE16A404; Tue, 24 Apr 2007 09:19:13 +0000 (UTC) (envelope-from yar@comp.chem.msu.su) Received: from comp.chem.msu.su (comp.chem.msu.su [158.250.32.97]) by mx1.freebsd.org (Postfix) with ESMTP id 583CA13C44B; Tue, 24 Apr 2007 09:19:06 +0000 (UTC) (envelope-from yar@comp.chem.msu.su) Received: from comp.chem.msu.su (localhost [127.0.0.1]) by comp.chem.msu.su (8.13.4/8.13.4) with ESMTP id l3O9J0TB076942; Tue, 24 Apr 2007 13:19:00 +0400 (MSD) (envelope-from yar@comp.chem.msu.su) Received: (from yar@localhost) by comp.chem.msu.su (8.13.4/8.13.4/Submit) id l3O9Ixoi076941; Tue, 24 Apr 2007 13:18:59 +0400 (MSD) (envelope-from yar) Date: Tue, 24 Apr 2007 13:18:59 +0400 From: Yar Tikhiy To: Coleman Kane Message-ID: <20070424091858.GA31094@comp.chem.msu.su> References: <200704211417.l3LEHUKK078832@repoman.freebsd.org> <462A27CD.5090006@freebsd.org> <1177170852.32761.0.camel@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1177170852.32761.0.camel@localhost> User-Agent: Mutt/1.5.9i Cc: Stephan Uphoff , cvs-src@FreeBSD.org, src-committers@FreeBSD.org, Andre Oppermann , cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/amd64/amd64 pmap.c src/sys/i386/i386 pmap.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Apr 2007 09:19:13 -0000 On Sat, Apr 21, 2007 at 09:54:12AM -0600, Coleman Kane wrote: > On Sat, 2007-04-21 at 17:03 +0200, Andre Oppermann wrote: > > Stephan Uphoff wrote: > > > ups 2007-04-21 14:17:30 UTC > > > > > > FreeBSD src repository > > > > > > Modified files: > > > sys/amd64/amd64 pmap.c > > > sys/i386/i386 pmap.c > > > Log: > > > Modify TLB invalidation handling. > > > > > > Reviewed by: alc@, peter@ > > > MFC after: 1 week > > > > Could you be a bit more verbose what changed here and why it > > was done? > > > > I agree. I would really like to know what the modification accomplishes. Alas, we don't live in an ideal world. If we did, our commit messages would always follow the well-known guideline: 0. Tell the essence of the change. 1. Give the reason for the change. 2. Explain the change unless it's trivial. -- Yar