Date: Mon, 24 Sep 2001 14:03:03 -0700 (PDT) From: Julian Elischer <julian@elischer.org> To: "Alexander N. Kabaev" <ak03@gte.com> Cc: freebsd-current@freebsd.org Subject: Re: KSE-related panic in NFS + patch Message-ID: <Pine.BSF.4.21.0109241402390.51124-100000@InterJet.elischer.org> In-Reply-To: <20010924155605.A3049@kanpc.gte.com>
next in thread | previous in thread | raw e-mail | index | archive | help
thanks
I'll fix it..
On Mon, 24 Sep 2001, Alexander N. Kabaev wrote:
> It appears that nfs_msg function in nfsclient/nfs_socket.c file
> is not prepared to deal with NULL thread pointer passed to it
> and bogusly tries to reference td->td_proc.
>
> I had to add this simple patch to avoid panics:
>
> Index: nfs_socket.c
> ===================================================================
> RCS file: /usr/ncvs/src/sys/nfsclient/nfs_socket.c,v
> retrieving revision 1.68
> diff -u -r1.68 nfs_socket.c
> --- nfs_socket.c 18 Sep 2001 23:31:51 -0000 1.68
> +++ nfs_socket.c 24 Sep 2001 19:39:21 -0000
> @@ -1364,6 +1364,6 @@
> nfs_msg(struct thread *td, char *server, char *msg)
> {
>
> - tprintf(td->td_proc, LOG_INFO, "nfs server %s: %s\n", server, msg);
> + tprintf((td ? td->td_proc : NULL), LOG_INFO, "nfs server %s: %s\n", server, msg);
> return (0);
> }
>
> #0 dumpsys () at ../../../kern/kern_shutdown.c:488
> #1 0xc01f1bc0 in boot (howto=260) at ../../../kern/kern_shutdown.c:331
> #2 0xc01f1ffd in panic (fmt=0xc030535e "from debugger")
> at ../../../kern/kern_shutdown.c:628
> #3 0xc0158a75 in db_panic (addr=-1069018059, have_addr=0, count=-1,
> modif=0xc8ddfae8 "") at ../../../ddb/db_command.c:443
> #4 0xc0158a15 in db_command (last_cmdp=0xc035c558, cmd_table=0xc035c398,
> aux_cmd_tablep=0xc0352d58, aux_cmd_tablep_end=0xc0352d5c)
> at ../../../ddb/db_command.c:341
> #5 0xc0158adf in db_command_loop () at ../../../ddb/db_command.c:465
> #6 0xc015ade3 in db_trap (type=12, code=0) at ../../../ddb/db_trap.c:72
> #7 0xc02d2ca0 in kdb_trap (type=12, code=0, regs=0xc8ddfc30)
> at ../../../i386/i386/db_interface.c:167
> #8 0xc02e04a0 in trap_fatal (frame=0xc8ddfc30, eva=0)
> at ../../../i386/i386/trap.c:931
> #9 0xc02e01f5 in trap_pfault (frame=0xc8ddfc30, usermode=0, eva=0)
> at ../../../i386/i386/trap.c:850
> #10 0xc02df9c8 in trap (frame={tf_fs = 24, tf_es = -849281008, tf_ds = -925040624,
> tf_edi = -849248992, tf_esi = -1044303808, tf_ebp = -924976000,
> tf_isp = -924976036, tf_ebx = -924975948, tf_edx = -1044650766, tf_ecx = 0,
> tf_eax = -924975948, tf_trapno = 12, tf_err = 0, tf_eip = -1069018059,
> tf_cs = 8, tf_eflags = 66178, tf_esp = 6, tf_ss = -1068979139})
> at ../../../i386/i386/trap.c:406
> #11 0xc0481435 in nfs_msg (td=0x0, server=0xc1bbe4f2 "tips8:/home/tips8",
> msg=0xc8ddfcb4 "not responding 10 > 9")
> at /usr/src/sys/modules/nfsclient/../../nfsclient/nfs_socket.c:1367
> #12 0xc0480f37 in nfs_timer (arg=0x0)
> at /usr/src/sys/modules/nfsclient/../../nfsclient/nfs_socket.c:1102
> #13 0xc01fa536 in softclock (dummy=0x0) at ../../../kern/kern_timeout.c:187
> #14 0xc01e588b in ithread_loop (arg=0xc17c9d00) at ../../../kern/kern_intr.c:532
> #15 0xc01e4d3a in fork_exit (callout=0xc01e5760 <ithread_loop>, arg=0xc17c9d00,
> frame=0xc8ddfd48) at ../../../kern/kern_fork.c:785
>
>
> To Unsubscribe: send mail to majordomo@FreeBSD.org
> with "unsubscribe freebsd-current" in the body of the message
>
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.21.0109241402390.51124-100000>