From owner-svn-ports-head@freebsd.org Fri Oct 7 06:44:31 2016 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 358B1BEC8F6; Fri, 7 Oct 2016 06:44:31 +0000 (UTC) (envelope-from mat@FreeBSD.org) Received: from prod2.absolight.net (mx3.absolight.net [IPv6:2a01:678:2:100::25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "plouf.absolight.net", Issuer "CAcert Class 3 Root" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id DA0A38A5; Fri, 7 Oct 2016 06:44:30 +0000 (UTC) (envelope-from mat@FreeBSD.org) Received: from prod2.absolight.net (localhost [127.0.0.1]) by prod2.absolight.net (Postfix) with ESMTP id 9BA18BDCEE; Fri, 7 Oct 2016 08:44:28 +0200 (CEST) Received: from atuin.in.mat.cc (48.196.7.109.rev.sfr.net [109.7.196.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by prod2.absolight.net (Postfix) with ESMTPSA id 68896BDCEA; Fri, 7 Oct 2016 08:44:28 +0200 (CEST) Subject: Re: svn commit: r423434 - head/security/openssl To: Bernard Spil References: <201610061938.u96JcmrW038201@repo.freebsd.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org From: Mathieu Arnold Organization: Absolight / The FreeBSD Foundation Message-ID: Date: Fri, 7 Oct 2016 08:44:24 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="dD0RkUa0WJNR3OOaMqDkuJcknKfXFgIQ2" X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 Oct 2016 06:44:31 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --dD0RkUa0WJNR3OOaMqDkuJcknKfXFgIQ2 Content-Type: multipart/mixed; boundary="rIaTaN7J9ucaJI8Gmk5n1oG2RNCHa3B88"; protected-headers="v1" From: Mathieu Arnold To: Bernard Spil Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Message-ID: Subject: Re: svn commit: r423434 - head/security/openssl References: <201610061938.u96JcmrW038201@repo.freebsd.org> In-Reply-To: --rIaTaN7J9ucaJI8Gmk5n1oG2RNCHa3B88 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Le 07/10/2016 =C3=A0 08:27, Bernard Spil a =C3=A9crit : > On 2016-10-07 0:44, Mathieu Arnold wrote: >> Le 06/10/2016 =C3=A0 21:38, Bernard Spil a =C3=A9crit : >>> Author: brnrd >>> Date: Thu Oct 6 19:38:48 2016 >>> New Revision: 423434 >>> URL: https://svnweb.freebsd.org/changeset/ports/423434 >>> >>> Log: >>> security/openssl: Fix ldconfig issue >>> >>> - OPT_USE=3D feature does not behave as expected >> >> I strongly disagree with that comment, the opt_USE works exactly as >> expected, and as documented. >> >>> Reported by: dinoex >>> Differential Revision: D8166 >>> >>> Modified: >>> head/security/openssl/Makefile >>> >>> Modified: head/security/openssl/Makefile >>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D >>> >>> --- head/security/openssl/Makefile Thu Oct 6 19:35:40 2016 =20 >>> (r423433) >>> +++ head/security/openssl/Makefile Thu Oct 6 19:38:48 2016 =20 >>> (r423434) >>> @@ -88,7 +88,7 @@ SCTP_CONFIGURE_OFF=3D no-sctp >>> SHARED_CONFIGURE_ON=3D shared >>> SHARED_MAKE_ENV=3D SHLIBVER=3D${OPENSSL_SHLIBVER} >>> SHARED_PLIST_SUB=3D SHLIBVER=3D${OPENSSL_SHLIBVER} >>> -SHARED_USE=3D ldconfig >>> +SHARED_USE=3D ldconfig=3Dyes >>> SSE2_CONFIGURE_OFF=3D no-sse2 >>> SSL2_CONFIGURE_ON=3D enable-ssl2 >>> SSL2_CONFIGURE_OFF=3D no-ssl2 >>> >>> > > Hi Mat, > > > From Mk/bsd.options.mk: > > 499: _u=3D ${option:C/=3D.*//g} > 500: USE_${_u:tu}+=3D ${option:C/.*=3D//g:C/,/ /g} > > If you forget to add =3Dvalue to your OPT_USE=3D feature this will resu= lt > in USE_FEATURE=3D feature as there's no `=3D' to split on. > This should either default to something sane (i.e. "yes") or throw an > error. Well, of course, if you just write USE_LDCONFIG, without =3Dyes, it won't= work either :-) --=20 Mathieu Arnold --rIaTaN7J9ucaJI8Gmk5n1oG2RNCHa3B88-- --dD0RkUa0WJNR3OOaMqDkuJcknKfXFgIQ2 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQJ8BAEBCgBmBQJX90RJXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQzQUI2OTc4OUQyRUQxMjEwNjQ0MEJBNUIz QTQ1MTZGMzUxODNDRTQ4AAoJEDpFFvNRg85IKvsP/2LlVt5iv79jxS50mraO2ZY/ Rm+j1tDs/ZAZP8cLHcGT/fUgmIYbJcUCrK80XuQfR4WvJW/jHeWuV0PAwQK3ZFu1 CAfsQebiKzPO+e0pX426+rE1bNUe/HtxndrDzg0n9N21D0mE06BuawUJF808KzQH 5YqABoiExi8ro11m+v7h1yoL8+G/iXU8dw7EZoZZLxAgWs+9xzmuRW1MbaGYcGEj I8zKjsghpuO7WjscKAQulSE7gilVdyLPL6X1B5YG/mVTN40kXtlBr4w2zEC10BGP 7Av7/Jc0rTxEzFJC9rKnAgSVylvZSaOLVz1sRJOZGQ/E4QDBckCxVueSwkB1Gq+u UVgELn4+H8fkzsyZfdetDATPfjv1KebWc5fV1pLeqpVS+lgFjjm6DnwCI3CYOa9X /rM+xdsC0+werjBfbD8L3Vc62f100g5+oFkQewaALSC7GCc+P9I89XIwytNOcfjc gq2ZimmOExOHDI/3S7Cxu5WAbGYOMeHiYzsmmrfulzm/Mbtby+C6cdzKhZRmvRwR igW+XQx/jYLg+u91KTLyyXhxF635KggnBEPzetycH4D1yfTM0oKzZjwnI7P40Iwt mCSyD7ylL5h1u8TA14F6To3+KEmudWuOWEnDwqee8zLgApZfhX52vZyUt3ATS7Fb SO3ZfBNHGkuv+/rBaTJf =yoA+ -----END PGP SIGNATURE----- --dD0RkUa0WJNR3OOaMqDkuJcknKfXFgIQ2--