From owner-freebsd-hackers@freebsd.org Fri Jun 1 18:12:44 2018 Return-Path: Delivered-To: freebsd-hackers@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E89A9FD583C for ; Fri, 1 Jun 2018 18:12:43 +0000 (UTC) (envelope-from jan@digitaldaemon.com) Received: from digitaldaemon.com (digitaldaemon.com [162.217.114.50]) by mx1.freebsd.org (Postfix) with SMTP id 676846A8D0 for ; Fri, 1 Jun 2018 18:12:43 +0000 (UTC) (envelope-from jan@digitaldaemon.com) Received: (qmail 6629 invoked by uid 89); 1 Jun 2018 18:06:01 -0000 Received: from c-24-0-179-87.hsd1.nj.comcast.net (HELO ?192.168.0.16?) (jan@digitaldaemon.com@24.0.179.87) by digitaldaemon.com with SMTP; 1 Jun 2018 18:06:01 -0000 Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (1.0) Subject: Re: PRs are being closed for bogus reasons :-( From: Jan Knepper X-Mailer: iPhone Mail (15E302) In-Reply-To: <20180601173705.77AFD72D@spqr.komquats.com> Date: Fri, 1 Jun 2018 14:06:00 -0400 Cc: Ian Lepore , "rb@gid.co.uk" , "freebsd-hackers@freebsd.org" Content-Transfer-Encoding: quoted-printable Message-Id: <922472F9-FC3C-46BA-9D7B-0CE1C53446B0@digitaldaemon.com> References: <20180601173705.77AFD72D@spqr.komquats.com> To: Cy Schubert X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Jun 2018 18:12:44 -0000 That sounds like a patch (HACK!) I submitted years (10+?} ago to have multip= le IPv4 addresses in a jail... :-) It was indeed not IPv6 ready... Jan ManiaC++ Jan Knepper > On Jun 1, 2018, at 13:37, Cy Schubert wrote: >=20 > Yes. Let me relay my experience. I received an IPv4 only hack (I hesitate t= o call it a patch). Reworking the submission to fix the immediate issue and i= ncrementally addresses IPv6 was unsatisfactory to the OP, as his suggested s= olution would have removed support for IPv6 entirely: his reply was he didn'= t use IPv6. >=20 > As a committer when sheepherding patches, one must consider the whole, not= someone's immediate beef. I've had many more experiences like this in ports= where one change might satisfy one locale while becoming a POLA violation f= or the rest of the community. Unfortunately when the answer is no or let's t= ry a compromise, feelings get hurt. >=20 > --- > Sent using a tiny phone keyboard. > Apologies for any typos and autocorrect. > Also, this old phone only supports top post. Apologies. >=20 > Cy Schubert > or > The need of the many outweighs the greed of the few. > --- >=20 > -----Original Message----- > From: Ian Lepore > Sent: 01/06/2018 08:18 > To: rb@gid.co.uk > Cc: freebsd-hackers@freebsd.org > Subject: Re: PRs are being closed for bogus reasons :-( >=20 > On Fri, 2018-06-01 at 15:53 +0100, rb@gid.co.uk wrote: >>>=20 >>> On 1 Jun 2018, at 15:41, Warner Losh wrote: >>>=20 >>>>=20 >>>> On Fri, Jun 1, 2018 at 8:10 AM, Bob Bishop wrote: >>>> Hi, >>>>=20 >>>>>=20 >>>>> On 31 May 2018, at 22:14, Poul-Henning Kamp wrote= : >>>>>=20 >>>>> -------- >>>>> In message=20 >>>>> , Warner Losh writes: >>>>>=20 >>>>>>=20 >>>>>> There's a problem with the PR database: there's too many bugs. >>>>> And despite the valiant efforts of a number of people over the >>>>> lifetime of the project, it has always had so many bugs that >>>>> everybody just threw their hands in the air and walked away. >>>>>=20 >>>>> The way to improve the situation is to fix PR's, not to complain >>>>> about PRs. >>>> Indeed. But look at the number of PRs with patches that are stuck in th= at state. Not pretty. >>> Over the years I've committed dozens of PRs that had patches in them. Th= e sad truth is that only about 10-15% of them have comitable patches in them= when submitted. And that number decays over time as things age in bugzilla.= [etc] >> Sure. But the best a non-comitter can do is to supply a patch tested agai= nst HEAD. If the patch rots because it hasn=C2=A2t been committed six months= down the line it=C2=A2s not my fault. >>=20 >=20 > The problem isn't bitrot, the problem is that many patches amount to > "here's a hack that works for me," and that isn't necessarily > committable. A committer typically has to do almost as much work to > figure out whether the patch is appropriate for all users on all arches > as they would have to do to develop a fix from scratch. Even if the > submitter has mad skills and submits a perfect patch, better than what > the committer would have done from scratch, the work to analyze > everything and decide whether that's the case still has to be done. >=20 > -- Ian >=20 > _______________________________________________ > freebsd-hackers@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-hackers > To unsubscribe, send any mail to "freebsd-hackers-unsubscribe@freebsd.org"= > _______________________________________________ > freebsd-hackers@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-hackers > To unsubscribe, send any mail to "freebsd-hackers-unsubscribe@freebsd.org"=