From owner-svn-src-head@freebsd.org Fri May 10 19:11:03 2019 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 24BE315AA9E4; Fri, 10 May 2019 19:11:03 +0000 (UTC) (envelope-from slw@zxy.spb.ru) Received: from zxy.spb.ru (zxy.spb.ru [195.70.199.98]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id B0E22877F5; Fri, 10 May 2019 19:11:02 +0000 (UTC) (envelope-from slw@zxy.spb.ru) Received: from slw by zxy.spb.ru with local (Exim 4.86 (FreeBSD)) (envelope-from ) id 1hPAv4-000BhF-4l; Fri, 10 May 2019 22:10:58 +0300 Date: Fri, 10 May 2019 22:10:58 +0300 From: Slawa Olhovchenkov To: Andrew Gallatin Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, kp@freebsd.org Subject: Re: svn commit: r347410 - in head: . sys/amd64/conf sys/arm/conf sys/arm64/conf sys/i386/conf sys/powerpc/conf sys/riscv/conf sys/sparc64/conf Message-ID: <20190510191058.GC65054@zxy.spb.ru> References: <201905092238.x49McFCO015665@repo.freebsd.org> <20190510124458.GB65054@zxy.spb.ru> <0842eef5-5f1f-c25a-a470-a424c536f1ed@cs.duke.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0842eef5-5f1f-c25a-a470-a424c536f1ed@cs.duke.edu> User-Agent: Mutt/1.5.24 (2015-08-30) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: slw@zxy.spb.ru X-SA-Exim-Scanned: No (on zxy.spb.ru); SAEximRunCond expanded to false X-Rspamd-Queue-Id: B0E22877F5 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.96 / 15.00]; NEURAL_HAM_MEDIUM(-0.99)[-0.994,0]; NEURAL_HAM_SHORT(-0.96)[-0.963,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 May 2019 19:11:03 -0000 On Fri, May 10, 2019 at 11:31:21AM -0400, Andrew Gallatin wrote: > On 2019-05-10 08:44, Slawa Olhovchenkov wrote: > > > pf have ifdef for IPSEC, but don't have support IPSEC_SUPPORT > > (netpfil/pf/if_pfsync.c). > > > > Thanks for pointing this out. It seems like IPSEC_SUPPORT would work > for this. I've made a patch, and it compiles and the pf module loads. > However, I have no knowledge of how to test it. Is this something > that you use, and which you can test? I am don't use pf, I am just explore kernel for ame reasson (IPSEC performance penalty) and see mostly IPSEC code ifdef to #if defined(IPSEC) || defined(IPSEC_SUPPORT) and only netpfil/pf/if_pfsync.c ifdef to #if defined(IPSEC) > Thanks, > > Drew > > diff --git a/sys/netpfil/pf/if_pfsync.c b/sys/netpfil/pf/if_pfsync.c > index 45b1e090f95c..cc06637b862e 100644 > --- a/sys/netpfil/pf/if_pfsync.c > +++ b/sys/netpfil/pf/if_pfsync.c > @@ -308,7 +308,7 @@ static void pfsync_bulk_update(void *); > static void pfsync_bulk_fail(void *); > > static void pfsync_detach_ifnet(struct ifnet *); > -#ifdef IPSEC > +#ifdef IPSEC_SUPPORT > static void pfsync_update_net_tdb(struct pfsync_tdb *); > #endif > static struct pfsync_bucket *pfsync_get_bucket(struct pfsync_softc *, > @@ -1228,7 +1228,7 @@ pfsync_in_tdb(struct pfsync_pkt *pkt, struct mbuf *m, int offset, int count) > { > int len = count * sizeof(struct pfsync_tdb); > > -#if defined(IPSEC) > +#if defined(IPSEC_SUPPORT) > struct pfsync_tdb *tp; > struct mbuf *mp; > int offp; > @@ -1249,7 +1249,7 @@ pfsync_in_tdb(struct pfsync_pkt *pkt, struct mbuf *m, int offset, int count) > return (len); > } > > -#if defined(IPSEC) > +#if defined(IPSEC_SUPPORT) > /* Update an in-kernel tdb. Silently fail if no tdb is found. */ > static void > pfsync_update_net_tdb(struct pfsync_tdb *pt) > _______________________________________________ > svn-src-all@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/svn-src-all > To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"