From owner-freebsd-cvsweb@FreeBSD.ORG Sat Oct 16 11:32:22 2004 Return-Path: Delivered-To: freebsd-cvsweb@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E3F8316A4CE for ; Sat, 16 Oct 2004 11:32:22 +0000 (GMT) Received: from smtp1.pp.htv.fi (smtp1.pp.htv.fi [213.243.153.34]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7434443D5C for ; Sat, 16 Oct 2004 11:32:22 +0000 (GMT) (envelope-from scop@FreeBSD.org) Received: from [62.78.130.203] (cs78130203.pp.htv.fi [62.78.130.203]) by smtp1.pp.htv.fi (Postfix) with ESMTP id E545B7FCAE; Sat, 16 Oct 2004 14:32:19 +0300 (EEST) From: Ville =?ISO-8859-1?Q?Skytt=E4?= To: freebsd-cvsweb@freebsd.org In-Reply-To: <58670.69.53.57.66.1097788341.squirrel@69.53.57.66> References: <200410142354.43039@kde_is_very_cool> <58670.69.53.57.66.1097788341.squirrel@69.53.57.66> Content-Type: text/plain Organization: FreeBSD Message-Id: <1097926338.2719.23.camel@bobcat.mine.nu> Mime-Version: 1.0 X-Mailer: Ximian Evolution 1.4.6 (1.4.6-2) Date: Sat, 16 Oct 2004 14:32:18 +0300 Content-Transfer-Encoding: 7bit cc: Krzysztof Lichota Subject: Re: cvsweb will not work like before :( X-BeenThere: freebsd-cvsweb@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS Web maintenance mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 16 Oct 2004 11:32:23 -0000 On Fri, 2004-10-15 at 00:12, Jon Noack wrote: > > For example in my PHP script I have the following printf() like string > > variable: > > $cvswebformat2="http://webcvs.kde.org/cgi-bin/cvsweb.cgi/~checkout~/kde-i18n/%s?rev=%s&content-type=text/plain"; > > where first "%s" is like fr/kdeadmin/kcron.po, and second "%s" is branch > > like KDE_3_3_BRANCH or HEAD. > > Actually, it works fine for "HEAD" or ".". According to the Changelog, > this functionality was "resurrected" on 2004-04-20. However, other > branches/tags I tried did not work. Right. It "works" for HEAD, because the requested tag/branch seems to be ignored altogether, and the magic revision "." currently results in -rHEAD being passed to "cvs co". I already started enhancing the "." revision so that it takes the branch into account, it seems to work pretty ok here. But there's a catch: https://ccvs.cvshome.org/issues/show_bug.cgi?id=211 What the above means is that before one can do a "cvs co -p" using a branch name (ie. -rBRANCH, == "latest on branch BRANCH"), BRANCH needs to be in CVSROOT/val-tags. "cvs co -p" does not put it there, but "cvs co" (without -p) does -> someone has to do the latter outside of cvsweb before it starts to work in it :( Additionally, the error messages from "cvs co -p" for nonexistent tags/branches are, well, non-obvious. This is as of cvs 1.11.17. I think I'll commit this stuff anyway today. If the above bug 211 doesn't get fixed in cvs soonish and this starts to cause problems, I'll take a look at changing "cvs co" to checkout into a temporary file in cvsweb, then operating on that instead of directly using the STDOUT from "cvs co -p". That might not be a bad idea in the first place, BTW.