From owner-svn-src-all@FreeBSD.ORG Fri Feb 6 17:01:56 2015 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id B37F5EAE; Fri, 6 Feb 2015 17:01:56 +0000 (UTC) Received: from bigwig.baldwin.cx (bigwig.baldwin.cx [IPv6:2001:470:1f11:75::1]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 6EA48DC7; Fri, 6 Feb 2015 17:01:53 +0000 (UTC) Received: from ralph.baldwin.cx (pool-173-54-116-245.nwrknj.fios.verizon.net [173.54.116.245]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id 75E49B91F; Fri, 6 Feb 2015 12:01:51 -0500 (EST) From: John Baldwin To: src-committers@freebsd.org Subject: Re: svn commit: r278321 - head/sys/dev/ipmi Date: Fri, 06 Feb 2015 12:00:02 -0500 Message-ID: <1747329.Lge6tErVCv@ralph.baldwin.cx> User-Agent: KMail/4.14.2 (FreeBSD/10.1-STABLE; KDE/4.14.2; amd64; ; ) In-Reply-To: <201502061645.t16GjBHI010251@svn.freebsd.org> References: <201502061645.t16GjBHI010251@svn.freebsd.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (bigwig.baldwin.cx); Fri, 06 Feb 2015 12:01:51 -0500 (EST) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, wca@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Feb 2015 17:01:56 -0000 On Friday, February 06, 2015 04:45:11 PM John Baldwin wrote: > Author: jhb > Date: Fri Feb 6 16:45:10 2015 > New Revision: 278321 > URL: https://svnweb.freebsd.org/changeset/base/278321 > > Log: > Use direct hardware access for internal requests for KCS and SMIC. In > particular, updates to the watchdog should no longer sleep. > - Add a new IPMI_IO_LOCK for low-level I/O access. Use this for > kcs_polled_request() and smic_polled_request(). > - Add a new backend callback "ipmi_driver_request" to handle a driver > request. The new callback performs the request sychronously for KCS > and SMIC. SSIF still defers the work to the worker thread since the > worker thread sleeps during request processing anyway. > - Allocate driver requests on the stack rather than using malloc(). > > Differential Revision: https://reviews.freebsd.org/D1723 > Tested by: scottl > MFC after: 2 weeks I think we should further change this to only allow the watchdog to be used with KCS and SMIC so that watchdog requests never sleep. I think that we could then revert r272366 as to my knowledge this was the only watchdog driver that could sleep? -- John Baldwin