Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 19 Nov 2012 08:26:28 -0800
From:      Rui Paulo <rpaulo@FreeBSD.org>
To:        Alexey Dokuchaev <danfe@FreeBSD.org>
Cc:        svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org
Subject:   Re: svn commit: r243262 - head/usr.bin/top
Message-ID:  <3241E07C-D177-4297-825A-A52FEA8F1241@FreeBSD.org>
In-Reply-To: <20121119082618.GB67020@FreeBSD.org>
References:  <201211190803.qAJ83eRo014127@svn.freebsd.org> <20121119082618.GB67020@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On 19 Nov 2012, at 00:26, Alexey Dokuchaev <danfe@FreeBSD.org> wrote:

> On Mon, Nov 19, 2012 at 08:03:40AM +0000, Rui Paulo wrote:
>> New Revision: 243262
>> URL: http://svnweb.freebsd.org/changeset/base/243262
>>=20
>> -	cmdbuf =3D (char *)malloc(cmdlengthdelta + 1);
>> +	cmdbuf =3D (char *)malloc(cmdlen + 1);
>=20
> Why explicitly casting malloc return() value (void *)?


Why are you asking me about code I didn't write? :-)
I don't want to mix style changes with functional changes so I let it =
be. If you're asking why our source tree has malloc casts, it's because =
compilers in the 1980s used to be unnecessarily more pedantic.

Regards,
--
Rui Paulo




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3241E07C-D177-4297-825A-A52FEA8F1241>