From owner-freebsd-current@FreeBSD.ORG  Sat Jul  3 18:22:40 2004
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from green.homeunix.org (freefall.freebsd.org [216.136.204.21])
	by hub.freebsd.org (Postfix) with ESMTP
	id E8D3816A4CE; Sat,  3 Jul 2004 18:22:39 +0000 (GMT)
Received: from green.homeunix.org (green@localhost [127.0.0.1])
	by green.homeunix.org (8.12.11/8.12.11) with ESMTP id i63IMlqA001000;
	Sat, 3 Jul 2004 14:22:47 -0400 (EDT)
	(envelope-from green@green.homeunix.org)
Received: (from green@localhost)
	by green.homeunix.org (8.12.11/8.12.11/Submit) id i63IMk1r000999;
	Sat, 3 Jul 2004 14:22:46 -0400 (EDT)
	(envelope-from green)
Date: Sat, 3 Jul 2004 14:22:46 -0400
From: Brian Fundakowski Feldman <green@freebsd.org>
To: ticso@cicely.de
Message-ID: <20040703182246.GA964@green.homeunix.org>
References: <20040703075555.GA65870@cicely5.cicely.de>
	<20040703101858.GB65870@cicely5.cicely.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20040703101858.GB65870@cicely5.cicely.de>
User-Agent: Mutt/1.5.6i
cc: freebsd-current@freebsd.org
cc: bmilekic@freebsd.org
Subject: Re: malloc(9) M_WAITOK broken
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 03 Jul 2004 18:22:40 -0000

On Sat, Jul 03, 2004 at 12:18:59PM +0200, Bernd Walter wrote:
> On Sat, Jul 03, 2004 at 09:55:56AM +0200, Bernd Walter wrote:
> > I get daily panics in vinum because malloc M_WAITOK returns NULL.
> > Source is from 1st Jul running on alpha.
> 
> Since vm_uma_core.c Rev 1.94 uma_zalloc_arg allways ignores M_WAITOK
> in the non WITNESS case because badness is initialized as 1.
> My understanding is that M_WAITOK shouldn't be ignored in any case
> to avoid returning NULL - at least malloc(9) is documented to never
> return NULL with M_WAITOK.

Please try an updated src/sys/vm/uma_core.c now (the rest of the build
is broken, so just try updating the last revision of that file.)

-- 
Brian Fundakowski Feldman                           \'[ FreeBSD ]''''''''''\
  <> green@FreeBSD.org                               \  The Power to Serve! \
 Opinions expressed are my own.                       \,,,,,,,,,,,,,,,,,,,,,,\