From owner-svn-src-head@freebsd.org  Thu Aug 23 22:18:53 2018
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 2C2F51099C53;
 Thu, 23 Aug 2018 22:18:53 +0000 (UTC)
 (envelope-from brooks@spindle.one-eyed-alien.net)
Received: from spindle.one-eyed-alien.net (spindle.one-eyed-alien.net
 [199.48.129.229])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id A4AA78AA7D;
 Thu, 23 Aug 2018 22:18:52 +0000 (UTC)
 (envelope-from brooks@spindle.one-eyed-alien.net)
Received: by spindle.one-eyed-alien.net (Postfix, from userid 3001)
 id EE7D95A9F13; Thu, 23 Aug 2018 22:18:45 +0000 (UTC)
Date: Thu, 23 Aug 2018 22:18:45 +0000
From: Brooks Davis <brooks@freebsd.org>
To: Conrad Meyer <cem@freebsd.org>
Cc: Alex Richardson <arichardson@freebsd.org>,
 src-committers <src-committers@freebsd.org>,
 svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject: Re: svn commit: r338270 - head/lib/libmd
Message-ID: <20180823221845.GA24975@spindle.one-eyed-alien.net>
References: <201808231819.w7NIJXDG072054@repo.freebsd.org>
 <CAG6CVpVjytnfv4Xm2DtxNEE+gJ33OEnHmZwD97x-iG6iX6gPyA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
 protocol="application/pgp-signature"; boundary="Kj7319i9nmIyA2yE"
Content-Disposition: inline
In-Reply-To: <CAG6CVpVjytnfv4Xm2DtxNEE+gJ33OEnHmZwD97x-iG6iX6gPyA@mail.gmail.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.27
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 23 Aug 2018 22:18:53 -0000


--Kj7319i9nmIyA2yE
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Aug 23, 2018 at 02:40:35PM -0700, Conrad Meyer wrote:
> On Thu, Aug 23, 2018 at 11:19 AM, Alex Richardson
> <arichardson@freebsd.org> wrote:
> > Author: arichardson
> > Date: Thu Aug 23 18:19:33 2018
> > New Revision: 338270
> > URL: https://svnweb.freebsd.org/changeset/base/338270
> >
> > Log:
> >   Don't build skein_block_asm.s if we don't have an as binary
> >...
> > It might also be better to just
> >   compile the C file in userspace since the compiler can the use SSE/AV=
X.
>=20
> FYI, in my (limited) testing, the hand-written assembly has something
> like 50% performance advantage over the reference C implementation,
> even with -march=3Dnative, etc.  Using the reference C version is
> totally fine for bootstrapping, but the compiler is not yet smart
> enough to write the assembler versions.

Thanks for doing this.  Sounds like we should keep the option to build
if you have a GNU as around.

-- Brooks

--Kj7319i9nmIyA2yE
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEcBAEBAgAGBQJbfzLFAAoJEKzQXbSebgfAD3IH/107LLKFZDLnzb4UBPaPcGHz
aVMsvHEJVsdBDuOWjpD8fhpT+8ss+QYLZMv5ickKuNbwCzrDyNp75UnehLPifvVQ
dNjtLmx92nD7APS59aURQxvE14VI3iQ0YWJ11AkA+IikNkQk8UUxJubRQXMELNTF
/b3/6KyTc0bw97Lx3o3JyXb3OaXL/VLEJcWM7Zbcv8JxoeFGhJ/y2llfV1xXMDl0
MzKmIF2lDHRs8fsIj1GK8xJlS9hbiTpEfK7sz2wneJdnFBk4uEQoU4iTvlSxBgQH
xNqo6/dFtjqZP5D7AgO52/38M8NGGHh+CSFPU5kjy48zOaR3BliClHWvifzYw1A=
=kVPm
-----END PGP SIGNATURE-----

--Kj7319i9nmIyA2yE--