From owner-freebsd-isdn Fri May 25 3:52:48 2001 Delivered-To: freebsd-isdn@freebsd.org Received: from smtp.alcove.fr (smtp.alcove.fr [212.155.209.139]) by hub.freebsd.org (Postfix) with ESMTP id A5B1237B422 for ; Fri, 25 May 2001 03:52:43 -0700 (PDT) (envelope-from nsouch@alcove.fr) Received: from koka.alcove-fr ([10.16.110.26] helo=koka.alcove-int ident=mail) by smtp.alcove.fr with esmtp (Exim 3.12 #1 (Debian)) id 153FCw-0000Xd-00; Fri, 25 May 2001 12:52:38 +0200 Received: from nsouch by koka.alcove-int with local (Exim 3.12 #1 (Debian)) id 153FCu-0006Nu-00; Fri, 25 May 2001 12:52:36 +0200 Date: Fri, 25 May 2001 12:52:36 +0200 From: Nicolas Souchu To: Gary Jennejohn Cc: freebsd-isdn@freebsd.org Subject: Re: Provider's LCP requests :( Message-ID: <20010525125236.A24495@koka.alcove-fr> References: <20010519234306.A12266@ontario.alcove-fr> <01052009280600.37452@peedub.muc.de> <01052011163602.37452@peedub.muc.de> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit User-Agent: Mutt/1.2.4i In-Reply-To: <01052011163602.37452@peedub.muc.de>; from garyj@jennejohn.org on Sun, May 20, 2001 at 11:16:36AM +0200 Organization: =?iso-8859-1?Q?Alc=F4ve=2C_http:=2F=2Fwww=2Ealcove=2Ecom?= Sender: owner-freebsd-isdn@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org On Sun, May 20, 2001 at 11:16:36AM +0200, Gary Jennejohn wrote: > > OK, I now know what the patch is supposed to do. Funny that it's only in > -current but never made it into -stable. > > Basically the patch adds 2 new fields to struct sppp - pp_last_{sent,recv}. > NOTE: this change to struct sppp means that you _must_ also recompile > spppcontrol ! > > The new fields are set in if_spppsubr.c whenever a "normal" packet goes > out/comes in over the interface in sppp_output() and sppp_input() resp. > Control packets such as LCP stuff should not be reflected since sppp_input() > should be exited early and sppp_output() isn't used to send such packets. > > There's a new routine in i4b_l4.c called i4b_get_idletime() which calls the > routine i4bisppp_idletime() in i4b_isppp.c if the interface is sppp. The > latter returns the larger of pp_last_sent and pp_last_recv. > > Now, i4b_get_idletime() is used in all the shorthold routines in i4b_l4.c to > get the active time. The returned value is used appropriately to figure out > whether the idle timeout has expired. > > Since the routines in if_spppsubr.c should only update the pp_last_* fields > for "normal" packets, traffic for control packets should never have any > effect on the idle timeout calculations. At least, that's the theory. I now understand and will check the code according to your info. Thanks! > > Did the patch apply cleanly ? I'd be amazed if it did. It did, I had to specify the source paths though. -- Nicolas.Souchu@fr.alcove.com Alcôve - Open Source Software Engineer - http://www.alcove.com To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-isdn" in the body of the message