From owner-freebsd-current@freebsd.org Tue Jul 9 14:48:56 2019 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A1C7D15DC597 for ; Tue, 9 Jul 2019 14:48:56 +0000 (UTC) (envelope-from sgk@troutmask.apl.washington.edu) Received: from troutmask.apl.washington.edu (troutmask.apl.washington.edu [128.95.76.21]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "troutmask", Issuer "troutmask" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4FDB66D139; Tue, 9 Jul 2019 14:48:55 +0000 (UTC) (envelope-from sgk@troutmask.apl.washington.edu) Received: from troutmask.apl.washington.edu (localhost [127.0.0.1]) by troutmask.apl.washington.edu (8.15.2/8.15.2) with ESMTPS id x69Emrar065893 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Tue, 9 Jul 2019 07:48:53 -0700 (PDT) (envelope-from sgk@troutmask.apl.washington.edu) Received: (from sgk@localhost) by troutmask.apl.washington.edu (8.15.2/8.15.2/Submit) id x69EmqQ9065892; Tue, 9 Jul 2019 07:48:52 -0700 (PDT) (envelope-from sgk) Date: Tue, 9 Jul 2019 07:48:52 -0700 From: Steve Kargl To: Niclas Zeising Cc: Hans Petter Selasky , Ian Lepore , freebsd-current@freebsd.org, takawata@freebsd.org Subject: Re: Someone broke USB Message-ID: <20190709144852.GA65885@troutmask.apl.washington.edu> Reply-To: sgk@troutmask.apl.washington.edu References: <20190708170323.GA59922@troutmask.apl.washington.edu> <20190708172414.GA60059@troutmask.apl.washington.edu> <20190708173030.GA60139@troutmask.apl.washington.edu> <08ded31d-b159-6400-cf69-ffb711eca66c@selasky.org> <2fbea10e-ae6c-fe77-f1bc-632c361dde07@selasky.org> <20190708200803.GA61032@troutmask.apl.washington.edu> <0c7badb9-ad29-1691-eed9-dc66ef8b581c@selasky.org> <20190709043301.GB63004@troutmask.apl.washington.edu> <83a114f5-5e59-de31-be35-f579d3a87ca5@freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable In-Reply-To: <83a114f5-5e59-de31-be35-f579d3a87ca5@freebsd.org> User-Agent: Mutt/1.11.4 (2019-03-13) X-Rspamd-Queue-Id: 4FDB66D139 X-Spamd-Bar: + Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [1.65 / 15.00]; ARC_NA(0.00)[]; HAS_REPLYTO(0.00)[sgk@troutmask.apl.washington.edu]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; NEURAL_SPAM_SHORT(0.43)[0.425,0]; NEURAL_HAM_LONG(-0.43)[-0.430,0]; MIME_GOOD(-0.10)[text/plain]; RCVD_TLS_LAST(0.00)[]; DMARC_NA(0.00)[washington.edu]; AUTH_NA(1.00)[]; RCPT_COUNT_FIVE(0.00)[5]; RCVD_COUNT_THREE(0.00)[3]; TO_MATCH_ENVRCPT_SOME(0.00)[]; MX_GOOD(-0.01)[cached: troutmask.apl.washington.edu]; REPLYTO_ADDR_EQ_FROM(0.00)[]; NEURAL_SPAM_MEDIUM(0.80)[0.804,0]; R_SPF_NA(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:73, ipnet:128.95.0.0/16, country:US]; MID_RHS_MATCH_FROM(0.00)[]; IP_SCORE(-0.04)[ip: (0.07), ipnet: 128.95.0.0/16(0.01), asn: 73(-0.21), country: US(-0.06)] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Jul 2019 14:48:56 -0000 On Tue, Jul 09, 2019 at 10:19:55AM +0200, Niclas Zeising wrote: > On 2019-07-09 06:33, Steve Kargl wrote: > > On Mon, Jul 08, 2019 at 10:54:24PM +0200, Hans Petter Selasky wrote: > >> On 2019-07-08 22:08, Steve Kargl wrote: > >>> On Mon, Jul 08, 2019 at 09:08:17PM +0200, Hans Petter Selasky wrote: > >>>> Hi Steve, > >>>> > >>>> Can you revert all prior patches and try this one instead. > >>>> > >>> > >>> With the new patch, none of the USB devices are found. > >>> I'll be away from the laptop for a few hours. > >>> > >> > >> I've put the USB ACPI code into an own module, which is not enabled by > >> default. So USB should be back to normal for now. > >> > >> https://svnweb.freebsd.org/changeset/base/349851 > >> > >=20 > > Thanks! Unfortunately, things have gone left. To update > > /usr/src to get your change, I pulled in some vm changes, > > which break the graphics/drm-legacy-kmod port. >=20 >=20 > Can you report this, including the failure you're seeing, to=20 > x11@freebsd.org or as an issue on the FreeBSDDesktop github? > Thanks! > Regards Mark's patch to deal with the removed vm_page_unhold() has gotten me past that problem. One none hits =3D=3D=3D> Building for drm-legacy-kmod-g20190523 =3D=3D=3D> drm (all) =3D=3D=3D> drm/drm (all) =3D=3D=3D> drm/mach64 (all) =3D=3D=3D> drm/mga (all) =3D=3D=3D> drm/r128 (all) =3D=3D=3D> drm/savage (all) =3D=3D=3D> drm/sis (all) =3D=3D=3D> drm/tdfx (all) =3D=3D=3D> drm/via (all) =3D=3D=3D> drm2 (all) =3D=3D=3D> drm2/drm2 (all) =3D=3D=3D> drm2/i915kms (all) cc -O2 -pipe -march=3Dcore2 -fno-strict-aliasing -march=3Dcore2 -Werror -= D_KERNEL -DKLD_MODULE -nostdinc -I. -I/usr/src/sys -I/usr/src/sys/contrib= /ck/include -fno-common -fdebug-prefix-map=3D./machine=3D/usr/src/sys/i386= /include -fdebug-prefix-map=3D./x86=3D/usr/src/sys/x86/include -MD -MF= =2Edepend.intel_iic.o -MTintel_iic.o -mno-mmx -mno-sse -msoft-float -ffrees= tanding -fwrapv -fstack-protector -Wall -Wredundant-decls -Wnested-externs = -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wcast-qual -Wunde= f -Wno-pointer-sign -D__printf__=3D__freebsd_kprintf__ -Wmissing-include-di= rs -fdiagnostics-show-option -Wno-unknown-pragmas -Wno-error-tautological-c= ompare -Wno-error-empty-body -Wno-error-parentheses-equality -Wno-error-unu= sed-function -Wno-error-pointer-sign -Wno-error-shift-negative-value -Wno-a= ddress-of-packed-member -mno-aes -mno-avx -std=3Diso9899:1999 -I/usr/port= s/graphics/drm-legacy-kmod/work/drm-legacy-12bd551/drm2/../src/ -c /usr/por= ts/graphics/drm-legacy-kmod/work/drm-legacy-12bd551/src/dev/drm2/i915/intel= _iic.c -o intel_iic.o /usr/ports/graphics/drm-legacy-kmod/work/drm-legacy-12bd551/src/dev/drm2/i9= 15/intel_iic.c:570:2: error: implicit declaration of function 'iicbus_set_n= ostop' is invalid in C99 [-Werror,-Wimplicit-function-declaration] iicbus_set_nostop(idev, true); ^ /usr/ports/graphics/drm-legacy-kmod/work/drm-legacy-12bd551/src/dev/drm2/i9= 15/intel_iic.c:570:2: error: this function declaration is not a prototype [= -Werror,-Wstrict-prototypes] 2 errors generated. *** Error code 1 Stop. make[4]: stopped in /usr/ports/graphics/drm-legacy-kmod/work/drm-legacy-12b= d551/drm2/i915kms *** Error code 1 Stop. make[3]: stopped in /usr/ports/graphics/drm-legacy-kmod/work/drm-legacy-12b= d551/drm2 *** Error code 1 Stop. make[2]: stopped in /usr/ports/graphics/drm-legacy-kmod/work/drm-legacy-12b= d551 *** Error code 1 Stop. make[1]: stopped in /usr/ports/graphics/drm-legacy-kmod *** Error code 1 Stop. make: stopped in /usr/ports/graphics/drm-legacy-kmod --=20 Steve