From owner-svn-ports-head@freebsd.org Fri Jul 19 11:17:40 2019 Return-Path: Delivered-To: svn-ports-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 295ACBF337; Fri, 19 Jul 2019 11:17:40 +0000 (UTC) (envelope-from ehaupt@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 0C16369A5B; Fri, 19 Jul 2019 11:17:40 +0000 (UTC) (envelope-from ehaupt@FreeBSD.org) Received: from [172.20.10.5] (unknown [1.127.193.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) (Authenticated sender: ehaupt) by smtp.freebsd.org (Postfix) with ESMTPSA id 8D2D6CEBB; Fri, 19 Jul 2019 11:16:41 +0000 (UTC) (envelope-from ehaupt@FreeBSD.org) Subject: Re: svn commit: r483807 - in head: Mk Mk/Uses audio/kwave audio/logitechmediaserver audio/supercollider audio/teamspeak3-server audio/wavpack audio/zynaddsubfx base/binutils cad/calculix cad/linuxcnc-d... To: Gerald Pfeifer , Michael Reifenberger Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org References: <201811021332.wA2DWZPm025383@repo.freebsd.org> From: Emanuel Haupt Openpgp: preference=signencrypt Message-ID: <3f711bda-7918-be14-c0c1-80b7c9596f78@FreeBSD.org> Date: Fri, 19 Jul 2019 19:16:27 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=iso-8859-15 Content-Language: en-US Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 0C16369A5B X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-2.98 / 15.00]; local_wl_from(0.00)[FreeBSD.org]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.98)[-0.977,0]; ASN(0.00)[asn:11403, ipnet:96.47.64.0/20, country:US] X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Jul 2019 11:17:40 -0000 On 10.07.19 03:37, Gerald Pfeifer wrote: > On Sat, 3 Nov 2018, Gerald Pfeifer wrote: >>> Modified: head/cad/openscad/Makefile >>> ============================================================================== >>> -#.if ${ARCH} == i386 && ${OSVERSION} >= 1100000 >>> +#.if ${ARCH} == i386 >>> #USE_GCC= yes >>> #.endif >> Yes, but this was dead code before and is still dead code. >> >> Okay to remove this, Michael? > > I see you made this change five months later as part of > > r495203 | mr | 2019-03-09 21:11:35 +0000 (Sa., 09 März 2019) | 3 lines > > Update to the 2019.03.03 pre-release and switch to QT5 so that the port > doesn't get deleted > during QT4 wipeout. > > so I'm removing this from my tracker. Less dead code is always good. :) > >>> Modified: head/devel/heimdall/Makefile >>> ============================================================================== >>> # does not compile with clang 6.0.0 >>> -.if ${OPSYS} == FreeBSD && ${OSVERSION} >= 1101513 >>> +.if ${OPSYS} == FreeBSD >>> USE_GCC= yes >>> .endif >> Yes, but shouldn't the .if simple be removed now? >> >> Okay, to do so, Emanuel? > > Thanks for the update you made shortly thereafter that also > addressed this, Emanuel! IMHO yes. The OPSYS checks were mostly introduced for compatibility with DragonflyBSD. As far as I know we no longer actively support Dragonfly. Emanuel